From: Takashi Iwai Subject: Re: [PATCH 2/2] wm8750: add missing VREF output Date: Mon, 11 Aug 2008 13:36:46 +0200 Message-ID: References: <1218444346-19153-1-git-send-email-dbaryshkov@gmail.com> <1218444346-19153-2-git-send-email-dbaryshkov@gmail.com> <20080811091119.GC9668@rakim.wolfsonmicro.main> <48A0025C.6000903@gmail.com> <20080811101939.GB5560@sirena.org.uk> <20080811104204.GC5560@sirena.org.uk> <20080811110046.GD5560@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (ns2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6F49E103847 for ; Mon, 11 Aug 2008 13:36:46 +0200 (CEST) In-Reply-To: <20080811110046.GD5560@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Dmitry Baryshkov , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 11 Aug 2008 12:01:00 +0100, Mark Brown wrote: > > On Mon, Aug 11, 2008 at 12:45:32PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > The long description is exactly what's broken - the names are wrong or > > > undeclared and since DAPM works based on the control names this causes > > > the drivers to fail to initialise DAPM for the device concerned. > > > Exactly such a text should appear in the changelog. > > Sure, my intention was to provide some appropriate text. > > > > It's > > > pretty much equivalent to C code referencing an undeclared variable. > > > Everyone knows C syntax but not ASoC implementation details. > > If the patch is pushed to stable tree, it should be described well so > > that other reviewers can understand it well. > > Sorry, there may have been a miscommunication here - this should only > *need* to go to 2.6.27 since the bulk registration functions are more > careful about checking error values than the hand rolled loops tended to > be. For earlier kernels people will either not notice or have already > have local patches so the bugs are not quite so serious. Ah, OK. So it's not for stable. (A detailed changelog would be still better, though :) > Obviously, it'd be good to fix for the earlier kernels but it's not > clear it is critical enough for them. I see. Thanks for clarification. thanks, Takashi