From: Takashi Iwai Subject: Re: Recent code changes for HD-audio on HG repo Date: Thu, 16 Aug 2007 15:37:54 +0200 Message-ID: References: <1187217195.12267.38.camel@nic-desktop> <1717EBB5-F362-4767-8D40-BFE2E17AFA9C@iol.it> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id F04C2243F2 for ; Thu, 16 Aug 2007 15:37:54 +0200 (CEST) In-Reply-To: <1717EBB5-F362-4767-8D40-BFE2E17AFA9C@iol.it> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Nicola Fagnani Cc: alsa-devel List-Id: alsa-devel@alsa-project.org At Thu, 16 Aug 2007 14:21:39 +0200, Nicola Fagnani wrote: > > > > Are you sure that you passed power_save_controller=0, not > > power_save=0? See below. > > > > Yes, I set power_save_controller=0. This should have disabled the > power save > timeout, preventing the call of azx_stop_chip(). So, GPIO isn't reset as long as the controller alive. It sounds reasonable. > > OK, it's an Intel Mac, right? Then maybe the culprit is the missing > > GPIO initialization. It's done only at creation time. > > Did you get the PM suspend/resume working with this machine? > > I guess you'll have the same problem, too. > > > > Right, I forgot that initialization and in fact the sound never > worked after a > suspend. > > > Anyway, try the patch below. Hopefully it fixes the power-save > > problem too. > > Yes, it does. :-) Great work! > It fixes suspend too :-D Thanks for confirmation. I committed it now to HG tree. Takashi