From: Takashi Iwai Subject: Re: [PATCH] ALSA: Use struct_size() helper Date: Fri, 24 May 2019 07:55:21 +0200 Message-ID: References: <20190523202917.GA12595@embeddedor> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190523202917.GA12595@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: " Gustavo A. R. Silva " Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 23 May 2019 22:29:17 +0200, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel) > > with: > > struct_size(data, channels, src_format->channels) > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied now, thanks. Takashi