From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: hda - program ICT bits to support HBR audio Date: Mon, 02 Oct 2017 11:26:12 +0200 Message-ID: References: <20170919222505.28654-1-pierre-louis.bossart@linux.intel.com> <8af5af38-f220-f58a-e7be-4e25dfff452a@linux.intel.com> <20170925145649.GA5063@subhransu-desktop> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 170722670B0 for ; Mon, 2 Oct 2017 11:26:13 +0200 (CEST) In-Reply-To: <20170925145649.GA5063@subhransu-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Subhransu S. Prusty" Cc: Sriram Periyasamy , alsa-devel@alsa-project.org, broonie@kernel.org, Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On Mon, 25 Sep 2017 16:56:53 +0200, Subhransu S. Prusty wrote: > > On Wed, Sep 20, 2017 at 08:12:36AM -0500, Pierre-Louis Bossart wrote: > > On 9/20/17 5:00 AM, Takashi Iwai wrote: > > >On Wed, 20 Sep 2017 00:25:05 +0200, > > >Pierre-Louis Bossart wrote: > > >> > > >>From: Sriram Periyasamy > > >> > > >>On recent Intel platforms (Haswell, Broadwell, Skylake, ApolloLake, > > >>KabyLake, ...), the IEC Coding Type (ICT) bitfield in the Digital > > >>Converter Control #3 needs to be set explicitly for HDMI/DisplayPort > > >>High Bit Rate (HBR) audio playback to work. This was not required in > > >>earlier platforms when HBR was first introduced. The ICT bits are > > >>defined in Section 7.3.3.9 of the HDaudio 1.0a specification. > > >> > > >>Since the ICT bitfield was not specified for HDAudio 1.0 devices > > >>(before 2009), we only program it on machines more recent than > > >>Haswell. > > >> > > >>We tested that this fix is not needed on Baytrail-I (MinnowBoard > > >>Turbot) and believe by extension it also does not apply to Braswell. > > >> > > >>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98797 > > >> > > >>Signed-off-by: Sriram Periyasamy > > >>Signed-off-by: Pierre-Louis Bossart > > >>Signed-off-by: Subhransu S. Prusty > > >>--- > > >>v2: move digi3 verb in Set section, only set ICT for haswell and newer > > > > > >Applied now with a slight fix (moving *_SET_* definition to the right > > >place). > > > > Thanks Takashi. Not sure what happened since I have a clear memory > > of doing that change and making a note of it... > > Hi Takashi, > > I think this patch should have also gone to stable. We didn't cc. Please > suggest whether we should submit it separately for stable. In such a case, please send a mail to Greg KH once after the patch gets merged to Linus tree and tell him the upstream git commit id to cherry-pick for stable kernels. thanks, Takashi