From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use Date: Wed, 11 Jan 2017 17:26:42 +0100 Message-ID: References: <20170111134013.3798733-1-arnd@arndb.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20170111134013.3798733-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 11 Jan 2017 14:39:44 +0100, Arnd Bergmann wrote: > > gcc-7 caught what it considers a NULL pointer dereference: > > sound/pci/hda/patch_ca0132.c: In function 'dspio_scp.constprop': > sound/pci/hda/patch_ca0132.c:1487:4: error: argument 1 null where non-null expected [-Werror=nonnull] > > This is plausible from looking at the function, as we compare 'reply' > to NULL earlier in it. I have not tried to analyze if there are constraints > that make it impossible to hit the bug, but adding another NULL check in > the end kills the warning and makes the function more robust. > > Signed-off-by: Arnd Bergmann Applied, thanks. Takashi