From: Takashi Iwai Subject: Re: [patch] oss/sb_audio: prevent divide by zero bug Date: Mon, 20 Aug 2012 10:24:35 +0200 Message-ID: References: <20120818155515.GA22424@elgon.mountain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id EE9B5265D22 for ; Mon, 20 Aug 2012 09:54:51 +0200 (CEST) In-Reply-To: <20120818155515.GA22424@elgon.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Dan Carpenter Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Sat, 18 Aug 2012 18:55:15 +0300, Dan Carpenter wrote: > > Speed comes from get_user() in audio_ioctl(). We use it to set the "s" > variable before clamping it to valid values so it could lead to a divide > by zero bug. > > Signed-off-by: Dan Carpenter Thanks, applied now. Takashi > diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c > index 733b014..b2b3c01 100644 > --- a/sound/oss/sb_audio.c > +++ b/sound/oss/sb_audio.c > @@ -575,13 +575,15 @@ static int jazz16_audio_set_speed(int dev, int speed) > if (speed > 0) > { > int tmp; > - int s = speed * devc->channels; > + int s; > > if (speed < 5000) > speed = 5000; > if (speed > 44100) > speed = 44100; > > + s = speed * devc->channels; > + > devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; > > tmp = 256 - devc->tconst; >