From: Takashi Iwai Subject: Re: [PATCH] Revised AT32 ASoC Patch Date: Wed, 04 Jun 2008 15:51:52 +0200 Message-ID: References: <200806031103.10785.geoffrey@pager.net> <20080604132806.GB2166@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 72B94243F9 for ; Wed, 4 Jun 2008 15:51:53 +0200 (CEST) In-Reply-To: <20080604132806.GB2166@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Geoffrey Wossum List-Id: alsa-devel@alsa-project.org At Wed, 4 Jun 2008 14:28:07 +0100, Mark Brown wrote: > > On Wed, Jun 04, 2008 at 02:01:55PM +0200, Takashi Iwai wrote: > > Geoffrey Wossum wrote: > > > > +struct at32_ssc_info { > > > + char *name; > > > + struct ssc_device *ssc; > > > + spinlock_t lock; /* lock for dir_mask */ > > > Just wondering whether this lock is really needed. > > Is it really racy? > > Bidirectional ports could be in two PCMs and have configuration > happening simultaneously. Fair enough. But, it's no fast code path, and maybe one global mutex would be enough for such a purpose, though. Takashi