From: Takashi Iwai Subject: Re: hw_params function and OSS emulation Date: Wed, 22 Aug 2007 23:57:29 +0200 Message-ID: References: <46CB2BB4.9060808@freescale.com> <46CC480F.7090604@freescale.com> <46CCA5E1.5050704@freescale.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mail.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id CAC20103804 for ; Wed, 22 Aug 2007 23:57:29 +0200 (CEST) In-Reply-To: <46CCA5E1.5050704@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: alsa-devel@alsa-project.org, Trent Piepho List-Id: alsa-devel@alsa-project.org At Wed, 22 Aug 2007 16:08:49 -0500, Timur Tabi wrote: > > Takashi Iwai wrote: > > > The buffer allocation in prepare callback would actually do work. > > I've never mentioned that it doesn't work. It's just not > > recommended, simply because the prepare is called more often than > > hw_params even without changing the parameters. > > What is the driver supposed to do on the second call to .prepare()? In other > words, what is the point of calling it multiple times in a row? Once my > driver is prepared to start, how could it become more prepared? The purpose of prepare callback is to make the PCM stream ready to start. (The trigger callbacks are supposed to be just triggering, not preparing the stream.) Usually, once after the PCM is triggered, the registers are no longer as same as the beginning. If you want to stop and restart the stream, you'll very likely to reset the registers again. That's why prepare is called again. (Or, your driver is always go-or-die? :) Takashi