From: Takashi Iwai Subject: Re: cmipci patch Date: Fri, 19 Jan 2007 14:33:55 +0100 Message-ID: References: <200701191122.05134.f.hammer@web.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200701191122.05134.f.hammer@web.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: f.hammer@web.de Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Fri, 19 Jan 2007 11:22:05 +0100, Felix Hammer wrote: > > hi > > according to this bug --> > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2491 > i attached the diff for commit. The patch looks OK, but please follow the standard coding style of the linux kernel, namely, remove spaces around parentheses. Also, give a proper changelog and a sign-off to merge. (See the main page of ALSA BTS.) thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV