Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A9FC2BA19 for ; Tue, 14 Apr 2020 06:55:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E56332072D for ; Tue, 14 Apr 2020 06:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="BgtMIU9n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E56332072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 46546168C; Tue, 14 Apr 2020 08:54:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 46546168C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586847342; bh=9rnrvcGdLBteTDyECimQ7UoizxJakJEYaQ75zYvQSYs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BgtMIU9nC2gTCG7GaLNXteyX96IC29bqi21LIBP3h2kWed47K+Yf9JXupIvTb/Twh AxMKtRDzTdfI1CtokPmTYuXZl7SFkn8ImSAdk30zB0EwIAWUHQLeizwdJAisbUlnMS JWZDEFVqfKVnB1u7yHo5yIOFb7oXCYn6nfoWnBbM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7CDFFF80126; Tue, 14 Apr 2020 08:54:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EA4F1F8013D; Tue, 14 Apr 2020 08:54:46 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 04F7FF80115 for ; Tue, 14 Apr 2020 08:54:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 04F7FF80115 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 735B7AB3D; Tue, 14 Apr 2020 06:54:35 +0000 (UTC) Date: Tue, 14 Apr 2020 08:54:34 +0200 Message-ID: From: Takashi Iwai To: yangerkun Subject: Re: [RFC v2] ALSA: control: fix a error handling exist in snd_ctl_elem_add In-Reply-To: <20200414065109.6923-1-yangerkun@huawei.com> References: <20200414065109.6923-1-yangerkun@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 14 Apr 2020 08:51:09 +0200, yangerkun wrote: > > CVE-2020-11725 report that 'count = info->owner' may result a > SIZE_OVERFLOW. 'info->owner' represent a pid, and actually, we should > use info->count. > > Signed-off-by: yangerkun The CVE report is simply wrong. info->owner is used intentionally for this specific API to add a user-space control. For the normal kernel kctls, the field is used indeed for storing the pid, but but the user-space kctl addition API usage is an exception. You can see the another use of info->count of field in the very same function at a later point and find it has a different meaning. The CVE should be disputed. thanks, Takashi > --- > sound/core/control.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > v1->v2: reword the patch head > > diff --git a/sound/core/control.c b/sound/core/control.c > index aa0c0cf182af..c77ca7f39637 100644 > --- a/sound/core/control.c > +++ b/sound/core/control.c > @@ -1431,7 +1431,7 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file, > return -ENOMEM; > > /* Check the number of elements for this userspace control. */ > - count = info->owner; > + count = info->count; > if (count == 0) > count = 1; > > -- > 2.21.1 >