From: Takashi Iwai Subject: Re: [PATCH v3 0/2] ALSA: Add PCM USER_PVERSION ioctl Date: Tue, 27 Jun 2017 13:58:16 +0200 Message-ID: References: <20170627102944.6836-1-tiwai@suse.de> <240adf1c-710c-d02c-994f-a9556577cc64@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AD88F266B63 for ; Tue, 27 Jun 2017 13:58:17 +0200 (CEST) In-Reply-To: <240adf1c-710c-d02c-994f-a9556577cc64@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: Vinod Koul , alsa-devel@alsa-project.org, "Subhransu S . Prusty" , Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On Tue, 27 Jun 2017 13:43:43 +0200, Takashi Sakamoto wrote: > > Hi, > > On Jun 27 2017 19:29, Takashi Iwai wrote: > > Hi, > > > > this is a revised patchset that is applied on top of the current > > for-next branch, in order to optimize the appl_ptr sync on x86-64, > > adapting the alsa-lib side change by Sakamoto-san's patchset. > > > > Basically it adds a new ioctl for receiving the supported PCM protocol > > version from user-space side, and change the mmap code to allow only > > disabling the PCM status record depending on the supported protocol > > version. The former patch is identical with the previous version, > > only the latter one differs. > > > > The corresponding alsa-lib patch will follow. > > > > > > thanks, > > > > Takashi > > > > === > > > > Takashi Iwai (2): > > ALSA: pcm: Add an ioctl to specify the supported protocol version > > ALSA: pcm: Disable only control mmap for explicit appl_ptr sync > > > > include/sound/pcm.h | 1 + > > include/uapi/sound/asound.h | 3 ++- > > sound/core/pcm_compat.c | 1 + > > sound/core/pcm_native.c | 29 ++++++++++++++++++++++++----- > > 4 files changed, 28 insertions(+), 6 deletions(-) > > Reviewed-by: Takashi Sakamoto > > I note that the idea of USER_PVERSION ioctl is itself worth for the > other interfaces/protocols such as control. In the > interfaces/protocols, many structures have reserved members. As > Iwai-san described in the first patch, when changing them to utilize > these reserved members, this idea is a solution to balance > compatibility and extensibility. OK, let's go with this. I'll merge this and also the alsa-lib patchsets. Thanks! Takashi