From: Takashi Iwai Subject: Re: [PATCH V2 2/7] BAT: Add common definitions and functions Date: Fri, 02 Oct 2015 12:57:29 +0200 Message-ID: References: <45f232d5170199a9ee31b39e47f173100927422b.1442993440.git.han.lu@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 99B792608CF for ; Fri, 2 Oct 2015 12:57:27 +0200 (CEST) In-Reply-To: <45f232d5170199a9ee31b39e47f173100927422b.1442993440.git.han.lu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: han.lu@intel.com Cc: bernard.gautier@intel.com, alsa-devel@alsa-project.org, caleb@crome.org, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org On Wed, 23 Sep 2015 09:48:50 +0200, han.lu@intel.com wrote: > > +#define TEMP_RECORD_FILE_NAME "/tmp/bat.wav" Using a fixed temporary file path on /tmp is bad in security. You'd need to create a temp file dynamically, or use only the passed file name by user. Takashi