From: Takashi Iwai Subject: Re: [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver Date: Fri, 29 May 2015 20:25:01 +0200 Message-ID: References: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> <1431341645-2457-6-git-send-email-vinod.koul@intel.com> <20150529174115.GR21577@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id DDF6C2668C5 for ; Fri, 29 May 2015 20:25:02 +0200 (CEST) In-Reply-To: <20150529174115.GR21577@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Vinod Koul , liam.r.girdwood@linux.intel.com, patches.audio@intel.com, Jeeja KP , "Subhransu S. Prusty" List-Id: alsa-devel@alsa-project.org At Fri, 29 May 2015 18:41:15 +0100, Mark Brown wrote: > > > +/* PCI register access. */ > > +static void pci_azx_writel(u32 value, u32 __iomem *addr) > > +{ > > + writel(value, addr); > > +} > > These wrappers are setting off alarm bells - why can't we just use the > called functions directly, and given the parameters (which have just a > raw pointer and value) what else could the implementation be? Tegra has no direct byte access but only aligned 32bit accesses. That's why we have the redirection. Takashi