From: Takashi Iwai Subject: Re: [PATCH] hda: Added mono mux mixer for some STAC92HD7XXX family codecs Date: Sat, 19 Jan 2008 10:40:53 +0100 Message-ID: References: <47911DCA.9070104@embeddedalley.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id B828C246B7 for ; Sat, 19 Jan 2008 10:40:54 +0100 (CET) In-Reply-To: <47911DCA.9070104@embeddedalley.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Matthew Ranostay Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 18 Jan 2008 16:44:42 -0500, Matthew Ranostay wrote: > > Some 92HD7XXX family codecs have a mono mux, added support for selecting the input path to the mono out. > > Signed-off-by: Matthew Ranostay Could you fix the coding-style issues reported by checkpatch.pl? > +static struct hda_input_mux stac92hd71bxx_mono_mux = { > + /* count set later */ This is a bit dangerous. In theory, we may have several hd-audio instances, e.g. an on-board and a graphic card. The local common variable may conflict between two instances. Rather copy the whole input_mux to spec, and modify locally. thanks, Takashi