From: Takashi Iwai Subject: Re: [PATCH] alsa-driver: portman2x4 code cleanup Date: Thu, 25 Jan 2007 12:57:08 +0100 Message-ID: References: <87ejpkjjm5.fsf@zebra.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 55CA1310 for ; Thu, 25 Jan 2007 12:57:09 +0100 (MET) Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 0A3E3121E2 for ; Thu, 25 Jan 2007 12:57:09 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Matthias Koenig Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 25 Jan 2007 10:56:41 +0100, Matthias Koenig wrote: > > Takashi Iwai writes: > >> > Also, added cpu_relax() in busy loops, and fixed unneeded > >> > initialization of variables. > >> > >> Ok, thanks > >> > >> > The code is now committed to ALSA HG tree. Please give it a try. > >> > >> Ah, I just tested and found that the rawmidi open/close callbacks > >> have to be defined and cannot be NULL. So the driver as it is > >> will oops if device will be opened. > >> Fixed this, now tested with amidi input/output on all ports works > >> fine. Patch is below. > > > > Thanks, applied now. > > > >> > BTW, if the driver works for you, we can move this to alsa-kernel tree > >> > so that it's merged to the upstream kernel... > >> > >> Great, yes I think it can then be moved to alsa-kernel tree. > > > > OK, I'll work on this tomorrow. > > Ok, I still found another minor issue. Probably we do not need > irqsave/irqrestore for the spinlock calls in the interrupt handler. > > Matthias > > Signed-off-by: Matthias Koenig > ===================================================================== > Summary: portman2x4 - do not use irqsave/irqrestore in IRQ handler > > Replace spin_lock_irqsave/spin_unlock_irqrestore with > spin_lock/spin_unlock in IRQ handler. Thanks, applied to HG tree now. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV