From: Takashi Iwai Subject: Re: [PATCH] Reset file->f_op in snd_card_file_remove() Date: Thu, 28 Sep 2006 12:08:35 +0200 Message-ID: References: <200609272127.51980.annabellesgarden@yahoo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <200609272127.51980.annabellesgarden@yahoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Karsten Wiese Cc: mingo@elte.hu, alsa-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Wed, 27 Sep 2006 21:27:51 +0200, Karsten Wiese wrote: > = > Hi > = > This patch helps prevent an oops on 2.6.18-rt3, > when my usb usx2y soundcard disconnects. > Physically disconnects or "rmmod uhci_hc" both oops 1in7. > = > With this patch still no oops after > 1000 disconnects. > = > Please apply/comment. > = > thanks, > Karsten > = > =3D=3D=3D > = > Reset file->f_op in snd_card_file_remove() > = > When passing here in response to an usb disconnect, > file->f_op has been replaced with a kmalloc()ed version, > that would only allow releases. > = > It will be free()ed later on in snd_card_free(). > Here it happened sometimes, that the free()ed, not NULLed file->f_op > caused an oops in module_put() called by fops_put() still later on. > = > Signed-off-by: Karsten Wiese snd_card_file_remove() is not a right place to do that, IMO. Could you check whether this problem still happens on post-2.6.18? There are a lot of fixes in this area after 2.6.18. Takashi > = > = > = > --- rt3/sound/core/init.c 2006-09-23 20:03:18.000000000 +0200 > +++ rt3-kw/sound/core/init.c 2006-09-27 20:44:54.000000000 +0200 > @@ -722,6 +722,7 @@ int snd_card_file_remove(struct snd_card > mfile =3D card->files; > while (mfile) { > if (mfile->file =3D=3D file) { > + file->f_op =3D NULL; > if (pfile) > pfile->next =3D mfile->next; > else > = > = > = > = > = > ___________________________________________________________ = > Der fr=FChe Vogel f=E4ngt den Wurm. Hier gelangen Sie zum neuen Yahoo! Ma= il: http://mail.yahoo.de > = ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE= VDEV