Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A7DC4338F for ; Wed, 4 Aug 2021 07:42:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83ACE60F35 for ; Wed, 4 Aug 2021 07:42:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83ACE60F35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4685116FE; Wed, 4 Aug 2021 09:41:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4685116FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628062933; bh=27quufkyia36D8c65EHTZ0/KxJahejZ8icoXRFvukRY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dUFHT1K6+IBJaDiH/pZi/JshVqIxrL81RdZAUlqcxZywoicZatG6rVlJah4lDQlIF gn96RmRpE/+KWBMxLwXup9H1vJgia/nBB8MdA+8u8638FtWoAQThXqJKXZGUSlJAuF ml+N5X2KvCPQyCwRknbIPrOk2HpVX+vbITBn7ZuE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BFCD4F801F7; Wed, 4 Aug 2021 09:41:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B29A8F8025F; Wed, 4 Aug 2021 09:41:14 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98966F8016C for ; Wed, 4 Aug 2021 09:41:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98966F8016C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="S5meWrFi"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="LUPG/ngi" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A3CF21FDB1 for ; Wed, 4 Aug 2021 07:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628062862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XKtdbL26x+5HwwKZL2BP3ORSUAu7ePeRNbtcEa+CYVo=; b=S5meWrFi9PBHS7lPfiX+nY9MwAmLi70mZZSoGgSO9VDPkavztjD1AK/tiWLfQeQ7R4kGST ENGbZUWYjKB3C4QnPqJCrLK7EOUPI/GsCfsjK8hFn9lHaUi5irxd/WSwNf6O+1fDAP1AVs LcfC154Nk5R9qf5tKjfTSA3MDUTcVBQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628062862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XKtdbL26x+5HwwKZL2BP3ORSUAu7ePeRNbtcEa+CYVo=; b=LUPG/ngiAp/KVOdooptk8egF7uV+SuGIUAIOO8rz3hVng3Zk6tEFmorqsEnpqnJHmz7I5l uWIKFE6qQ1JxY8Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 94531A3B89 for ; Wed, 4 Aug 2021 07:41:02 +0000 (UTC) Date: Wed, 04 Aug 2021 09:41:02 +0200 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: memalloc: Store snd_dma_buffer.addr for continuous pages, too In-Reply-To: <20210804063415.3076-1-tiwai@suse.de> References: <20210804063415.3076-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 04 Aug 2021 08:34:15 +0200, Takashi Iwai wrote: > > In the recent fix commit eda80d7c9c4d ("ALSA: memalloc: Fix regression > with SNDRV_DMA_TYPE_CONTINUOUS"), we replaced the pfn argument of the > remap_page_pfn() call from the uninitialized dmab->addr. It was the > right fix, but it'd be more generic if we actually initialize > dmab->area for SNDRV_DMA_TYPE_CONTINOUS, too. e.g. the field is used > in the common snd_sgbuf_get_addr(), too. > > This patch adds the initialization of addr field and does revert of > the previous change to refer to it again in the mmap call. > > Signed-off-by: Takashi Iwai Scratch this one, an old patch was submitted wrongly. Will resubmit the right one. Takashi