Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B231C4338F for ; Sat, 24 Jul 2021 08:07:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ADD460E0C for ; Sat, 24 Jul 2021 08:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8ADD460E0C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6AF531768; Sat, 24 Jul 2021 10:06:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6AF531768 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627114020; bh=lQvcx332K4qSNAr4S0VUT1oHkG1fLuybqh9stSzLzDA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V8yppE8RAIf8kDP1c6kJNp4mC2vfVDtkX6JhjQ3/ynq5LcpQj2mJEKowqdUkRqvVe 5STw0hjyU0G20439YdYK+O4lN6AHRqfw6IbcENl7w/SLpb0A1VslnPARNu9XaNsk8r xKEuHGlUu+do1xRbCcmKaE9alKdXg6/2Y7ydSljQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 093BAF800F0; Sat, 24 Jul 2021 10:06:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A145F80227; Sat, 24 Jul 2021 10:06:08 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3BA60F800F0 for ; Sat, 24 Jul 2021 10:06:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3BA60F800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="NARFNJjf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="js88NVis" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B98472001D; Sat, 24 Jul 2021 08:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627113963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9AiQ8cZONeV5Db2uTffyzV8eCEwnWurc6Fi0JnKDII=; b=NARFNJjfQ/E131noRADAOBKCdFUvc/AoXQoJ+UDwyRlhm1afPG/ddfAZz6cIULbrY3K0iK Ci+bL2D1+rKC3NhFCw9gwQMJxsFTLHZ9B9vLmSIMNuoq2Es6WgY+LXb38017LdHkEx+Gzy AKZ26+9I0YD2N01zDITTvmtsj9/T/5k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627113963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9AiQ8cZONeV5Db2uTffyzV8eCEwnWurc6Fi0JnKDII=; b=js88NVisTI/bmqS+JoHMtMdtyeKkE52oZ2WpewuwWH3KmjkyCM/fQQpntbS9WwenUfGLQ0 3x9Yrt5U51a6+GCw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B276EA3B8A; Sat, 24 Jul 2021 08:06:03 +0000 (UTC) Date: Sat, 24 Jul 2021 10:06:03 +0200 Message-ID: From: Takashi Iwai To: "Geoffrey D. Bennett" Subject: Re: [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Hin-Tak Leung , alsa-devel@alsa-project.org, Vladimir Sadovnikov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 22 Jul 2021 22:11:40 +0200, Geoffrey D. Bennett wrote: > > Hi Takashi, > > In the sound-5.14-rc1 merge commit log the highlights included: > "Scarlett2 mixer code fixes and enhancements". I think that the new > support for Gen 3 devices is significant enough to be worth > mentioning. > > Can you add to the next update a note along the lines of "Support for > Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface > proprietary mixer controls"? > > This set of patches is relative to v5.14-rc2 and fixes four issues: > > 1. The Mute/Dim/MSD Mode controls are missing the direction/function > parts of the syntax of standard control names as per > Documentation/sound/designs/control-names.rst > > - This could be considered a breaking-stable change if someone is > relying on the Mute/Dim control names not changing. I think it's > unlikely to be a problem as this driver is still considered > experimental and not enabled by default, but if never changing > control names is important, then you can drop this patch. > > 2. The Direct Monitor control on the 2i2 interface is an Enum, not a > Switch. > > - This changes a control name, but that control was only introduced in > v5.14-rc1, so not a problem to change it now. > > 3. Fixes the mute status not being correctly read when the mute button > is pressed. > > - Not applicable for stable; those controls were introduced in > v5.14-rc1. > > 4. Sends the correct notification on line out and speaker switching > changes. > > - Partly applicable to stable, but will need a separate patch. > > Thanks, > Geoffrey. > > Geoffrey D. Bennett (4): > ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names > ALSA: scarlett2: Fix Direct Monitor control name for 2i2 > ALSA: scarlett2: Correct channel mute status after mute button pressed > ALSA: scarlett2: Fix line out/speaker switching notifications Applied all four patches now. Thanks. Takashi