Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258E1C433E2 for ; Fri, 28 Aug 2020 07:34:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C312071B for ; Fri, 28 Aug 2020 07:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oQZNWjB1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99C312071B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10EFE184E; Fri, 28 Aug 2020 09:33:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10EFE184E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598600051; bh=eMkS3RSxXa7ZvbV59HyxV1yjUUFrqIBg7RhfyqgGgDY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oQZNWjB10btzq0IY4DQdRC51MFu1Jl5gIKkeUpwMLreOby/1BOPy2LybS7utGxSZn omJfJNFHpn3Izze1UTYTJe5d6UA9smIAwG2lPHBJrt/J1jkO3ykj0CQKWB71xAAzeq 1sSDimlQmoFysRsRN/+UcvJC8om8TkcUhc2dH5YE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0E618F80143; Fri, 28 Aug 2020 09:33:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DEE6CF8016F; Fri, 28 Aug 2020 09:33:15 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 21424F80105 for ; Fri, 28 Aug 2020 09:33:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21424F80105 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1E20AB6DA; Fri, 28 Aug 2020 07:33:41 +0000 (UTC) Date: Fri, 28 Aug 2020 09:33:08 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH v2] ALSA: HDA: Early Forbid of runtime PM In-Reply-To: <1598569536-9450-1-git-send-email-harshapriya.n@intel.com> References: <1598569536-9450-1-git-send-email-harshapriya.n@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Harsha Priya , Emmanuel Jillela , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 28 Aug 2020 01:05:36 +0200, Harsha Priya wrote: > > For certain codecs (like Realtek), pm_runtime_forbid() is invoked > in the probe function after build_controls(). In a stress test, > its observed occasionally that runtime PM calls are invoked > before controls are built. This causes the codec to be > runtime suspended before probe completes. Because of this, not all > controls are enumerated correctly, and audio does not work until > system is rebooted. > > This issue being common across all codecs, pm_runtime_forbid() is > called when the codec object is created to fix this issue. > A codec enables or disables runtime pm in its own probe function. > > Multiple stress tests of 2000+ cycles has been done to test the fix. > > Signed-off-by: Harsha Priya > Signed-off-by: Emmanuel Jillela > Reviewed-by: Kailang Yang Thanks. The only concern is about the influence on the relevant ASoC code, especially hdac_hda.c. Kai, could you check whether this still works? Takashi > --- > sound/pci/hda/hda_codec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index e96a87f1b611..a356c21edb90 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -1000,6 +1000,9 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card, > if (err < 0) > goto error; > > + /* PM runtime needs to be enabled later after binding codec */ > + pm_runtime_forbid(&codec->core.dev); > + > return 0; > > error: > -- > 2.17.1 >