From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: hda - program ICT bits to support HBR audio Date: Wed, 20 Sep 2017 12:00:30 +0200 Message-ID: References: <20170919222505.28654-1-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 85E2F267234 for ; Wed, 20 Sep 2017 12:00:31 +0200 (CEST) In-Reply-To: <20170919222505.28654-1-pierre-louis.bossart@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: Sriram Periyasamy , alsa-devel@alsa-project.org, broonie@kernel.org, "Subhransu S . Prusty" List-Id: alsa-devel@alsa-project.org On Wed, 20 Sep 2017 00:25:05 +0200, Pierre-Louis Bossart wrote: > > From: Sriram Periyasamy > > On recent Intel platforms (Haswell, Broadwell, Skylake, ApolloLake, > KabyLake, ...), the IEC Coding Type (ICT) bitfield in the Digital > Converter Control #3 needs to be set explicitly for HDMI/DisplayPort > High Bit Rate (HBR) audio playback to work. This was not required in > earlier platforms when HBR was first introduced. The ICT bits are > defined in Section 7.3.3.9 of the HDaudio 1.0a specification. > > Since the ICT bitfield was not specified for HDAudio 1.0 devices > (before 2009), we only program it on machines more recent than > Haswell. > > We tested that this fix is not needed on Baytrail-I (MinnowBoard > Turbot) and believe by extension it also does not apply to Braswell. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98797 > > Signed-off-by: Sriram Periyasamy > Signed-off-by: Pierre-Louis Bossart > Signed-off-by: Subhransu S. Prusty > --- > v2: move digi3 verb in Set section, only set ICT for haswell and newer Applied now with a slight fix (moving *_SET_* definition to the right place). thanks, Takashi