From: Takashi Iwai Subject: Re: [PATCH v2] drm/i915: set proper N/CTS in modeset Date: Fri, 25 Sep 2015 10:11:02 +0200 Message-ID: References: <1443144972-81982-1-git-send-email-libin.yang@intel.com> <877fnfnd03.fsf@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <877fnfnd03.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: daniel.vetter@ffwll.ch, alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org List-Id: alsa-devel@alsa-project.org T24gRnJpLCAyNSBTZXAgMjAxNSAxMDowMTo0OCArMDIwMCwKSmFuaSBOaWt1bGEgd3JvdGU6Cj4g Cj4gT24gRnJpLCAyNSBTZXAgMjAxNSwgbGliaW4ueWFuZ0BpbnRlbC5jb20gd3JvdGU6Cj4gPiBG cm9tOiBMaWJpbiBZYW5nIDxsaWJpbi55YW5nQGludGVsLmNvbT4KPiA+Cj4gPiBXaGVuIG1vZGVz ZXQgb2NjdXJzIGFuZCB0aGUgVE1EUyBmcmVxdWVuY3kgaXMgc2V0IHRvIHNvbWUKPiA+IHNwZWlj YWwgdmFsdWVzLCB0aGUgTi9DVFMgbmVlZCB0byBiZSBzZXQgbWFudWFsbHkgaWYgYXVkaW8KPiA+ IGlzIHBsYXlpbmcuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogTGliaW4gWWFuZyA8bGliaW4ueWFu Z0BpbnRlbC5jb20+Cj4gCj4gUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp bnRlbC5jb20+CgpOb3cgYWxsIDQgcGF0Y2hlcyBhcmUgYXBwbGllZCB0byB0b3BpYy9kcm0tc3lu Yy1hdWRpby1yYXRlLgogIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVs L2dpdC90aXdhaS9zb3VuZC5naXQgdG9waWMvZHJtLXN5bmMtYXVkaW8tcmF0ZQoKSXQgd2FzIG1l cmdlZCBiYWNrIHRvIHNvdW5kIGZvci1uZXh0IGJyYW5jaCwgdG9vLgoKRmVlbCBmcmVlIHRvIG1l cmdlIHRoaXMgYnJhbmNoIGludG8gZHJtIHRyZWUuCgoKdGhhbmtzLAoKVGFrYXNoaQoKPiAKPiAK PiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMgfCA1NyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ID4gIGluY2x1ZGUvZHJtL2k5MTVf Y29tcG9uZW50LmggICAgICAgfCAxMCArKysrKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA1OCBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXVkaW8uYwo+ID4gaW5kZXggZTNjMzJjZS4uNjQyZGZiZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F1ZGlvLmMKPiA+IEBAIC0xMjgsNiArMTI4LDIwIEBAIHN0YXRpYyBpbnQgYXVk aW9fY29uZmlnX2dldF9uKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLCBpbnQg cmF0ZSkKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyB1aW50MzJfdCBh dWRpb19jb25maWdfc2V0dXBfbl9yZWcoaW50IG4sIHVpbnQzMl90IHZhbCkKPiA+ICt7Cj4gPiAr CWludCBuX2xvdywgbl91cDsKPiA+ICsJdWludDMyX3QgdG1wID0gdmFsOwo+ID4gKwo+ID4gKwlu X2xvdyA9IG4gJiAweGZmZjsKPiA+ICsJbl91cCA9IChuID4+IDEyKSAmIDB4ZmY7Cj4gPiArCXRt cCAmPSB+KEFVRF9DT05GSUdfVVBQRVJfTl9NQVNLIHwgQVVEX0NPTkZJR19MT1dFUl9OX01BU0sp Owo+ID4gKwl0bXAgfD0gKChuX3VwIDw8IEFVRF9DT05GSUdfVVBQRVJfTl9TSElGVCkgfAo+ID4g KwkJCShuX2xvdyA8PCBBVURfQ09ORklHX0xPV0VSX05fU0hJRlQpIHwKPiA+ICsJCQlBVURfQ09O RklHX05fUFJPR19FTkFCTEUpOwo+ID4gKwlyZXR1cm4gdG1wOwo+ID4gK30KPiA+ICsKPiA+ICAv KiBjaGVjayB3aGV0aGVyIE4vQ1RTL00gbmVlZCBiZSBzZXQgbWFudWFsbHkgKi8KPiA+ICBzdGF0 aWMgYm9vbCBhdWRpb19yYXRlX25lZWRfcHJvZyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ ICAJCQkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ID4gQEAgLTI2Miw5ICsyNzYs MTQgQEAgc3RhdGljIHZvaWQgaHN3X2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yLAo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSBjb25uZWN0b3ItPmRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpp bnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+ID4gIAllbnVt IHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gPiArCXN0cnVjdCBpOTE1X2F1ZGlvX2Nv bXBvbmVudCAqYWNvbXAgPSBkZXZfcHJpdi0+YXVkaW9fY29tcG9uZW50Owo+ID4gIAljb25zdCB1 aW50OF90ICplbGQgPSBjb25uZWN0b3ItPmVsZDsKPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqaW50ZWxfZGlnX3BvcnQgPQo+ID4gKwkJZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5i YXNlKTsKPiA+ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+cG9ydDsKPiA+ICAJ dWludDMyX3QgdG1wOwo+ID4gIAlpbnQgbGVuLCBpOwo+ID4gKwlpbnQgbiwgcmF0ZTsKPiA+ICAK PiA+ICAJRFJNX0RFQlVHX0tNUygiRW5hYmxlIGF1ZGlvIGNvZGVjIG9uIHBpcGUgJWMsICV1IGJ5 dGVzIEVMRFxuIiwKPiA+ICAJCSAgICAgIHBpcGVfbmFtZShwaXBlKSwgZHJtX2VsZF9zaXplKGVs ZCkpOwo+ID4gQEAgLTMwMiwxMiArMzIxLDI5IEBAIHN0YXRpYyB2b2lkIGhzd19hdWRpb19jb2Rl Y19lbmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICAJLyogRW5hYmxl IHRpbWVzdGFtcHMgKi8KPiA+ICAJdG1wID0gSTkxNV9SRUFEKEhTV19BVURfQ0ZHKHBpcGUpKTsK PiA+ICAJdG1wICY9IH5BVURfQ09ORklHX05fVkFMVUVfSU5ERVg7Cj4gPiAtCXRtcCAmPSB+QVVE X0NPTkZJR19OX1BST0dfRU5BQkxFOwo+ID4gIAl0bXAgJj0gfkFVRF9DT05GSUdfUElYRUxfQ0xP Q0tfSERNSV9NQVNLOwo+ID4gIAlpZiAoaW50ZWxfcGlwZV9oYXNfdHlwZShpbnRlbF9jcnRjLCBJ TlRFTF9PVVRQVVRfRElTUExBWVBPUlQpKQo+ID4gIAkJdG1wIHw9IEFVRF9DT05GSUdfTl9WQUxV RV9JTkRFWDsKPiA+ICAJZWxzZQo+ID4gIAkJdG1wIHw9IGF1ZGlvX2NvbmZpZ19oZG1pX3BpeGVs X2Nsb2NrKG1vZGUpOwo+ID4gKwo+ID4gKwl0bXAgJj0gfkFVRF9DT05GSUdfTl9QUk9HX0VOQUJM RTsKPiA+ICsJaWYgKGF1ZGlvX3JhdGVfbmVlZF9wcm9nKGludGVsX2NydGMsIG1vZGUpKSB7Cj4g PiArCQlpZiAoIWFjb21wKQo+ID4gKwkJCXJhdGUgPSAwOwo+ID4gKwkJZWxzZSBpZiAocG9ydCA+ PSBQT1JUX0EgJiYgcG9ydCA8PSBQT1JUX0UpCj4gPiArCQkJcmF0ZSA9IGFjb21wLT5hdWRfc2Ft cGxlX3JhdGVbcG9ydF07Cj4gPiArCQllbHNlIHsKPiA+ICsJCQlEUk1fRVJST1IoImludmFsaWQg cG9ydDogJWRcbiIsIHBvcnQpOwo+ID4gKwkJCXJhdGUgPSAwOwo+ID4gKwkJfQo+ID4gKwkJbiA9 IGF1ZGlvX2NvbmZpZ19nZXRfbihtb2RlLCByYXRlKTsKPiA+ICsJCWlmIChuICE9IDApCj4gPiAr CQkJdG1wID0gYXVkaW9fY29uZmlnX3NldHVwX25fcmVnKG4sIHRtcCk7Cj4gPiArCQllbHNlCj4g PiArCQkJRFJNX0RFQlVHX0tNUygibm8gc3VpdGFibGUgTiB2YWx1ZSBpcyBmb3VuZFxuIik7Cj4g PiArCX0KPiA+ICsKPiA+ICAJSTkxNV9XUklURShIU1dfQVVEX0NGRyhwaXBlKSwgdG1wKTsKPiA+ ICAKPiA+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+YXZfbXV0ZXgpOwo+ID4gQEAgLTU5NCw5 ICs2MzAsMTAgQEAgc3RhdGljIGludCBpOTE1X2F1ZGlvX2NvbXBvbmVudF9zeW5jX2F1ZGlvX3Jh dGUoc3RydWN0IGRldmljZSAqZGV2LAo+ID4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpp bnRlbF9kaWdfcG9ydDsKPiA+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4gPiAgCXN0cnVj dCBkcm1fZGlzcGxheV9tb2RlICptb2RlOwo+ID4gKwlzdHJ1Y3QgaTkxNV9hdWRpb19jb21wb25l bnQgKmFjb21wID0gZGV2X3ByaXYtPmF1ZGlvX2NvbXBvbmVudDsKPiA+ICAJZW51bSBwaXBlIHBp cGUgPSAtMTsKPiA+ICAJdTMyIHRtcDsKPiA+IC0JaW50IG5fbG93LCBuX3VwLCBuOwo+ID4gKwlp bnQgbjsKPiA+ICAKPiA+ICAJLyogSFNXLCBCRFcgU0tMIG5lZWQgdGhpcyBmaXggKi8KPiA+ICAJ aWYgKCFJU19TS1lMQUtFKGRldl9wcml2KSAmJgo+ID4gQEAgLTYzMCw2ICs2NjcsOSBAQCBzdGF0 aWMgaW50IGk5MTVfYXVkaW9fY29tcG9uZW50X3N5bmNfYXVkaW9fcmF0ZShzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gPiAgCQkJCSAgcGlwZV9uYW1lKHBpcGUpLCBwb3J0X25hbWUocG9ydCkpOwo+ID4g IAltb2RlID0gJmNydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ID4gIAo+ID4gKwkv KiBwb3J0IG11c3QgYmUgdmFsaWQgbm93LCBvdGhlcndpc2UgdGhlIHBpcGUgd2lsbCBiZSBpbnZh bGlkICovCj4gPiArCWFjb21wLT5hdWRfc2FtcGxlX3JhdGVbcG9ydF0gPSByYXRlOwo+ID4gKwo+ ID4gIAkvKiAyLiBjaGVjayB3aGV0aGVyIHRvIHNldCB0aGUgTi9DVFMvTSBtYW51YWxseSBvciBu b3QgKi8KPiA+ICAJaWYgKCFhdWRpb19yYXRlX25lZWRfcHJvZyhjcnRjLCBtb2RlKSkgewo+ID4g IAkJdG1wID0gSTkxNV9SRUFEKEhTV19BVURfQ0ZHKHBpcGUpKTsKPiA+IEBAIC02NDksMTUgKzY4 OSwxMCBAQCBzdGF0aWMgaW50IGk5MTVfYXVkaW9fY29tcG9uZW50X3N5bmNfYXVkaW9fcmF0ZShz dHJ1Y3QgZGV2aWNlICpkZXYsCj4gPiAgCQltdXRleF91bmxvY2soJmRldl9wcml2LT5hdl9tdXRl eCk7Cj4gPiAgCQlyZXR1cm4gMDsKPiA+ICAJfQo+ID4gLQluX2xvdyA9IG4gJiAweGZmZjsKPiA+ IC0Jbl91cCA9IChuID4+IDEyKSAmIDB4ZmY7Cj4gPiAgCj4gPiAtCS8qIDQuIHNldCB0aGUgTi9D VFMvTSAqLwo+ID4gKwkvKiAzLiBzZXQgdGhlIE4vQ1RTL00gKi8KPiA+ICAJdG1wID0gSTkxNV9S RUFEKEhTV19BVURfQ0ZHKHBpcGUpKTsKPiA+IC0JdG1wICY9IH4oQVVEX0NPTkZJR19VUFBFUl9O X01BU0sgfCBBVURfQ09ORklHX0xPV0VSX05fTUFTSyk7Cj4gPiAtCXRtcCB8PSAoKG5fdXAgPDwg QVVEX0NPTkZJR19VUFBFUl9OX1NISUZUKSB8Cj4gPiAtCQkJKG5fbG93IDw8IEFVRF9DT05GSUdf TE9XRVJfTl9TSElGVCkgfAo+ID4gLQkJCUFVRF9DT05GSUdfTl9QUk9HX0VOQUJMRSk7Cj4gPiAr CXRtcCA9IGF1ZGlvX2NvbmZpZ19zZXR1cF9uX3JlZyhuLCB0bXApOwo+ID4gIAlJOTE1X1dSSVRF KEhTV19BVURfQ0ZHKHBpcGUpLCB0bXApOwo+ID4gIAo+ID4gIAltdXRleF91bmxvY2soJmRldl9w cml2LT5hdl9tdXRleCk7Cj4gPiBAQCAtNjc4LDYgKzcxMyw3IEBAIHN0YXRpYyBpbnQgaTkxNV9h dWRpb19jb21wb25lbnRfYmluZChzdHJ1Y3QgZGV2aWNlICppOTE1X2RldiwKPiA+ICB7Cj4gPiAg CXN0cnVjdCBpOTE1X2F1ZGlvX2NvbXBvbmVudCAqYWNvbXAgPSBkYXRhOwo+ID4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXZfdG9faTkxNShpOTE1X2Rldik7Cj4gPiAr CWludCBpOwo+ID4gIAo+ID4gIAlpZiAoV0FSTl9PTihhY29tcC0+b3BzIHx8IGFjb21wLT5kZXYp KQo+ID4gIAkJcmV0dXJuIC1FRVhJU1Q7Cj4gPiBAQCAtNjg1LDYgKzcyMSw5IEBAIHN0YXRpYyBp bnQgaTkxNV9hdWRpb19jb21wb25lbnRfYmluZChzdHJ1Y3QgZGV2aWNlICppOTE1X2RldiwKPiA+ ICAJZHJtX21vZGVzZXRfbG9ja19hbGwoZGV2X3ByaXYtPmRldik7Cj4gPiAgCWFjb21wLT5vcHMg PSAmaTkxNV9hdWRpb19jb21wb25lbnRfb3BzOwo+ID4gIAlhY29tcC0+ZGV2ID0gaTkxNV9kZXY7 Cj4gPiArCUJVSUxEX0JVR19PTihNQVhfUE9SVFMgIT0gSTkxNV9NQVhfUE9SVFMpOwo+ID4gKwlm b3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShhY29tcC0+YXVkX3NhbXBsZV9yYXRlKTsgaSsrKQo+ ID4gKwkJYWNvbXAtPmF1ZF9zYW1wbGVfcmF0ZVtpXSA9IDA7Cj4gPiAgCWRldl9wcml2LT5hdWRp b19jb21wb25lbnQgPSBhY29tcDsKPiA+ICAJZHJtX21vZGVzZXRfdW5sb2NrX2FsbChkZXZfcHJp di0+ZGV2KTsKPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9pOTE1X2NvbXBvbmVu dC5oIGIvaW5jbHVkZS9kcm0vaTkxNV9jb21wb25lbnQuaAo+ID4gaW5kZXggZTZkMzVkNy4uODlk YzdkNiAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvZHJtL2k5MTVfY29tcG9uZW50LmgKPiA+ICsr KyBiL2luY2x1ZGUvZHJtL2k5MTVfY29tcG9uZW50LmgKPiA+IEBAIC0yNCw4ICsyNCwxOCBAQAo+ ID4gICNpZm5kZWYgX0k5MTVfQ09NUE9ORU5UX0hfCj4gPiAgI2RlZmluZSBfSTkxNV9DT01QT05F TlRfSF8KPiA+ICAKPiA+ICsvKiBNQVhfUE9SVCBpcyB0aGUgbnVtYmVyIG9mIHBvcnQKPiA+ICsg KiBJdCBtdXN0IGJlIHN5bmMgd2l0aCBJOTE1X01BWF9QT1JUUyBkZWZpbmVkIGk5MTVfZHJ2LmgK PiA+ICsgKiA1IHNob3VsZCBiZSBlbm91Z2ggYXMgb25seSBIU1csIEJEVywgU0tMIG5lZWQgc3Vj aCBmaXguCj4gPiArICovCj4gPiArI2RlZmluZSBNQVhfUE9SVFMgNQo+ID4gKwo+ID4gIHN0cnVj dCBpOTE1X2F1ZGlvX2NvbXBvbmVudCB7Cj4gPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsKPiA+ICsJ LyoqCj4gPiArCSAqIEBhdWRfc2FtcGxlX3JhdGU6IHRoZSBhcnJheSBvZiBhdWRpbyBzYW1wbGUg cmF0ZSBwZXIgcG9ydAo+ID4gKwkgKi8KPiA+ICsJaW50IGF1ZF9zYW1wbGVfcmF0ZVtNQVhfUE9S VFNdOwo+ID4gIAo+ID4gIAljb25zdCBzdHJ1Y3QgaTkxNV9hdWRpb19jb21wb25lbnRfb3BzIHsK PiA+ICAJCXN0cnVjdCBtb2R1bGUgKm93bmVyOwo+ID4gLS0gCj4gPiAxLjkuMQo+ID4KPiAKPiAt LSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK