From: Takashi Iwai Subject: Re: [PATCH 1/2] ASoC: DPCM: make some DPCM API calls non static for compressed usage Date: Thu, 16 Jan 2014 17:02:44 +0100 Message-ID: References: <1389804717-5985-1-git-send-email-liam.r.girdwood@linux.intel.com> <20140116123153.GP15567@sirena.org.uk> <20140116144042.GG25466@intel.com> <20140116145904.GI25466@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 259A4261A1C for ; Thu, 16 Jan 2014 17:02:45 +0100 (CET) In-Reply-To: <20140116145904.GI25466@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: Liam Girdwood , alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org At Thu, 16 Jan 2014 20:29:04 +0530, Vinod Koul wrote: > > On Thu, Jan 16, 2014 at 04:55:34PM +0100, Takashi Iwai wrote: > > At Thu, 16 Jan 2014 20:10:42 +0530, > > Vinod Koul wrote: > > > > > > On Thu, Jan 16, 2014 at 12:31:53PM +0000, Mark Brown wrote: > > > > On Wed, Jan 15, 2014 at 04:51:56PM +0000, Liam Girdwood wrote: > > > > > The ASoC compressed code needs to call the internal DPCM APIs in order to > > > > > dynamically route compressed data to different DAIs. > > > > > > > > Applied, thanks. I'm holding off on the second patch for a little so > > > > Vinod has a chance to say something since it's compressed stuff. > > > Both look good to me, so > > > > > > Acked-by: Vinod Koul > > > > > > The second patch still needs an update for properly copying the hw_params. This > > > was one of issue reported by qcom folks, but I don't want to hold these now. We > > > can fix that as it will impact systems not have fixup function for BEs. > > > > One thing that makes me a bit nervous is that it's accessing the > > actual PCM object. So far, sound/pcm.h is included there just because > > it's re-using the same enum definitions, etc, but it doesn't mean that > > it allows accessing a PCM object or function. > > > > If we bind a real PCM instance there, we should add the Kconfig > > selection for SND_PCM from SND_COMPRESS_OFFLOAD. > > Makes sense, but is this a practical sceanrios. I dont think we have a sound > card which supports offload only so SND_PCM will always be selected. > > This is also ASoC patch, so SND_SOC would be selected, which selects SND_PCM OK, then that's fine. thanks, Takashi