From: Takashi Iwai Subject: Re: [PATCH 14/14] sound/ppc: Use printf extension %pR for struct resource Date: Mon, 22 Nov 2010 07:44:04 +0100 Message-ID: References: <434a77317cc09300e79b7768170eec7ae04adb92.1289597644.git.joe@perches.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id A5C5A103830 for ; Mon, 22 Nov 2010 07:44:04 +0100 (CET) In-Reply-To: <434a77317cc09300e79b7768170eec7ae04adb92.1289597644.git.joe@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Joe Perches Cc: alsa-devel@alsa-project.org, Jiri Kosina , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Fri, 12 Nov 2010 13:38:04 -0800, Joe Perches wrote: > > Using %pR standardizes the struct resource output. > > Signed-off-by: Joe Perches Applied now. Thanks. Takashi > --- > sound/ppc/pmac.c | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c > index 8508117..b47cfd4 100644 > --- a/sound/ppc/pmac.c > +++ b/sound/ppc/pmac.c > @@ -1228,10 +1228,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return) > chip->rsrc[i].start + 1, > rnames[i]) == NULL) { > printk(KERN_ERR "snd: can't request rsrc " > - " %d (%s: 0x%016llx:%016llx)\n", > - i, rnames[i], > - (unsigned long long)chip->rsrc[i].start, > - (unsigned long long)chip->rsrc[i].end); > + " %d (%s: %pR)\n", > + i, rnames[i], &chip->rsrc[i]); > err = -ENODEV; > goto __error; > } > @@ -1256,10 +1254,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return) > chip->rsrc[i].start + 1, > rnames[i]) == NULL) { > printk(KERN_ERR "snd: can't request rsrc " > - " %d (%s: 0x%016llx:%016llx)\n", > - i, rnames[i], > - (unsigned long long)chip->rsrc[i].start, > - (unsigned long long)chip->rsrc[i].end); > + " %d (%s: %pR)\n", > + i, rnames[i], &chip->rsrc[i]); > err = -ENODEV; > goto __error; > } > -- > 1.7.3.1.g432b3.dirty >