From: Takashi Iwai Subject: Re: [PATCH] sound/oss/pss: Fix test of unsigned in pss_reset_dsp() and pss_download_boot() Date: Thu, 17 Dec 2009 12:36:22 +0100 Message-ID: References: <4B28085A.6020101@gmail.com> <4B2902C3.3080606@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id AE9441038B6 for ; Thu, 17 Dec 2009 12:36:22 +0100 (CET) In-Reply-To: <4B2902C3.3080606@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Roel Kluin Cc: alsa-devel@alsa-project.org, LKML , Andrew Morton List-Id: alsa-devel@alsa-project.org At Wed, 16 Dec 2009 16:54:43 +0100, Roel Kluin wrote: > > limit and jiffies are unsigned so the test did not work. > > Signed-off-by: Roel Kluin > --- > Found using coccinelle: http://coccinelle.lip6.fr/ > > >> - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) > >> + for (i = 0; i < 32768 && (limit >= jiffies); i++) > > > > No, it should use time_after_eq(limit, jiffies) instead. > > > > > > thanks, > > > > Takashi > > > > Ok, Applied now. Thanks. Takashi > > diff --git a/sound/oss/pss.c b/sound/oss/pss.c > index 83f5ee2..e19dd5d 100644 > --- a/sound/oss/pss.c > +++ b/sound/oss/pss.c > @@ -269,7 +269,7 @@ static int pss_reset_dsp(pss_confdata * devc) > unsigned long i, limit = jiffies + HZ/10; > > outw(0x2000, REG(PSS_CONTROL)); > - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) > + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) > inw(REG(PSS_CONTROL)); > outw(0x0000, REG(PSS_CONTROL)); > return 1; > @@ -369,11 +369,11 @@ static int pss_download_boot(pss_confdata * devc, unsigned char *block, int size > outw(0, REG(PSS_DATA)); > > limit = jiffies + HZ/10; > - for (i = 0; i < 32768 && (limit - jiffies >= 0); i++) > + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) > val = inw(REG(PSS_STATUS)); > > limit = jiffies + HZ/10; > - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) > + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) > { > val = inw(REG(PSS_STATUS)); > if (val & 0x4000) > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >