From: Takashi Iwai Subject: Re: [PATCH] add the nvidia HDMI codec driverfor MCP77/79 Date: Wed, 17 Sep 2008 16:04:55 +0200 Message-ID: References: <200809031558156739794@gmail.com> <15F501D1A78BD343BE8F4D8DB854566B31F8F744@hkemmail01.nvidia.com> <48BE7EE4.8020800@insite.cz> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 78CC324617 for ; Wed, 17 Sep 2008 16:04:56 +0200 (CEST) In-Reply-To: <200809171700022814652@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: peerchen Cc: Wei Ni , Peer Chen , alsa-devel , linux-kernel , akpm , Pavel Hofman List-Id: alsa-devel@alsa-project.org At Wed, 17 Sep 2008 17:00:04 +0800, peerchen wrote: > > new patch base on git tree. > > Signed-off-by: Wei Ni > Signed-off-by: Peer Chen Thanks! But, the patch looks like no "rebase". You secretly added a new function call that wasn't in your previous patch, namely... > diff -uprN -X linux-2.6-tiwai-sound/Documentation/dontdiff linux-2.6-tiwai-sound/sound/pci/hda/hda_intel.c linux-2.6-tiwai-sound-niwei/sound/pci/hda/hda_intel.c > --- linux-2.6-tiwai-sound/sound/pci/hda/hda_intel.c 2008-09-10 17:40:52.000000000 +0800 > +++ linux-2.6-tiwai-sound-niwei/sound/pci/hda/hda_intel.c 2008-09-10 17:49:31.000000000 +0800 > @@ -1220,6 +1220,9 @@ static int __devinit azx_codec_create(st > if (err < 0) > return err; > > + if (chip->driver_type == AZX_DRIVER_NVIDIA) > + chip->bus->needs_damn_long_delay = 1; > + Do we really need this inevitably? I don't think so -- otherwise I would have far more bug reports. This flag is the last resort and should be avoided as much as possible. This results in a significant slow down of suspend/resume speed, for example. If it's really needed with some devices and there is no other way to fix it, add this flag rather in the codec-initialization part. Also, if you resend a patch, please add the original patch description again. This helps my patch work a lot indeed. thanks, Takashi