From: Takashi Iwai Subject: Re: [PATCH] ASoC: Add WM8580 CODEC driver Date: Wed, 06 Aug 2008 15:21:37 +0200 Message-ID: References: <1218025106-1360-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7853C24151 for ; Wed, 6 Aug 2008 15:21:37 +0200 (CEST) In-Reply-To: <1218025106-1360-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 6 Aug 2008 13:18:26 +0100, Mark Brown wrote: > > +static inline unsigned int wm8580_read(struct snd_soc_codec *codec, > + unsigned int reg) > +{ > + switch (reg) { > + default: > + return wm8580_read_reg_cache(codec, reg); > + } Any addition in future? Otherwise let's remove unneeded switch. > +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) Could you rewrite the code to follow the recent i2c framework? Then you can reduce lots of codes. thanks, Takashi