From: Takashi Iwai Subject: Re: [PATCH v2] asoc: restrict sample rate and size in Freescale MPC8610 sound drivers Date: Tue, 29 Jul 2008 15:37:16 +0200 Message-ID: References: <1217282679-16103-1-git-send-email-timur@freescale.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id DB7621038BD for ; Tue, 29 Jul 2008 15:37:16 +0200 (CEST) In-Reply-To: <1217282679-16103-1-git-send-email-timur@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 28 Jul 2008 17:04:39 -0500, Timur Tabi wrote: > > The Freescale MPC8610 SSI device has the option of using one clock for both > transmit and receive (synchronous mode), or independent clocks (asynchronous). > The SSI driver, however, programs the SSI into synchronous mode and then > tries to program the clock registers independently. The result is that the wrong > sample size is usually generated during recording. > > This patch fixes the discrepancy by restricting the sample rate and sample size > of the playback and capture streams. The SSI driver remembers which stream > is opened first. When a second stream is opened, that stream is constrained > to the same sample rate and size as the first stream. > > A future version of this driver will lift the sample size restriction. > Supporting independent sample rates is more difficult, because only certain > codecs provide dual independent clocks. > > Signed-off-by: Timur Tabi Thanks, applied. Takashi