Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB55C433FE for ; Thu, 10 Dec 2020 18:59:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BC6023440 for ; Thu, 10 Dec 2020 18:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BC6023440 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6DBEC166C; Thu, 10 Dec 2020 19:58:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6DBEC166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607626763; bh=LKoRqcpkU+ZRAT/1dT/RntAhSq/eQKNBUlpU+YYEnpU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GEvlpd0wh12SWOKXDh4dLUCURa8IbOti1QuOqHzaynyOUh6WuLUUJ4cRwPTuykHFr iRgZpsCX7lHJMmDlghDbNhTWmpHLwx1s/xZj8QX8XoG/f4uBJuuBVrKThS2FgsMHSz U5AwMxzT6g2quue+5MqFqcGbzpAAaw73y8LcR4qg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B6953F80164; Thu, 10 Dec 2020 19:58:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C5738F8016E; Thu, 10 Dec 2020 19:58:29 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4BDF3F80105 for ; Thu, 10 Dec 2020 19:58:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4BDF3F80105 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86581AC79; Thu, 10 Dec 2020 18:58:22 +0000 (UTC) Date: Thu, 10 Dec 2020 19:58:22 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH v2] ALSA: hda/hdmi: fix silent stream for first playback to DP In-Reply-To: <20201210174445.3134104-1-kai.vehmanen@linux.intel.com> References: <20201210174445.3134104-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Harsha Priya , Emmanuel Jillela , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 10 Dec 2020 18:44:45 +0100, Kai Vehmanen wrote: > > A problem exists in enabling silent stream when connection type is > DisplayPort. Silent stream programming is completed when a new DP > receiver is connected, but infoframe transmission does not actually > start until PCM is opened for the first time. This can result in audible > gap of multiple seconds. This only affects the first PCM open. > > Fix the issue by properly assigning a converter to the silent stream, > and modifying the required stream ID programming sequence. > > This change only affects Intel display audio codecs. > > BugLink: https://github.com/thesofproject/linux/issues/2468 > Fixes: 951894cf30f4 ("ALSA: hda/hdmi: Add Intel silent stream support") > Signed-off-by: Kai Vehmanen > --- > sound/pci/hda/patch_hdmi.c | 98 +++++++++++++++++++++++++++++++++----- > 1 file changed, 86 insertions(+), 12 deletions(-) > > v2 changes: > - locking missing in silent_stream_disable() Applied now. Thanks. Takashi