From: Takashi Iwai Subject: Re: [PATCH v3 01/12] ASoC: intel: boards: define some general functions for hdac_hdmi Date: Thu, 11 Apr 2019 16:47:42 +0200 Message-ID: References: <1554992400-28777-1-git-send-email-libin.yang@intel.com> <1554992400-28777-2-git-send-email-libin.yang@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33397F89616 for ; Thu, 11 Apr 2019 16:47:42 +0200 (CEST) In-Reply-To: <1554992400-28777-2-git-send-email-libin.yang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: libin.yang@intel.com Cc: alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com List-Id: alsa-devel@alsa-project.org On Thu, 11 Apr 2019 16:19:49 +0200, libin.yang@intel.com wrote: > > +static int hdac_hdmi_add_device_link(struct device *consumer, > + struct device *supplier, > + struct device_link **link) Missing inline? But, before sending v4, please hold on. I'm thinking whether we can do this rather in the component init of the hdac-hdmi codec driver. Can't we get the machine device somehow at the time of codec component init? Or even if it's too early, there is also late_probe callback that is called after binding all... If we can manage to create a link from the codec side, we need to change only one place, instead of scattering allover the tree. thanks, Takashi