From: Takashi Iwai Subject: Re: [PATCH 1/1] seq: arecordmidi: Add num-events option Date: Mon, 11 Feb 2019 09:14:58 +0100 Message-ID: References: <5c4fb010.1c69fb81.94ca0.01ae@mx.google.com> <20190129084502.GA9419@workstation> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 334DD2673E2 for ; Mon, 11 Feb 2019 09:14:59 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Prashant Malani Cc: alsa-devel@alsa-project.org, Clemens Ladisch List-Id: alsa-devel@alsa-project.org On Mon, 11 Feb 2019 05:23:36 +0100, Prashant Malani wrote: > > Friendly ping. Since no one raised objection, I applied now. thanks, Takashi > On Mon, Feb 4, 2019 at 12:20 PM Prashant Malani > wrote: > > > Friendly ping. Sounds like Clemens mentioned atoi() should be OK (given > > his explanation regarding non-numeric strings, along with consistency with > > the rest of the utility). > > Are there any other concerns with this patchset? > > > > Thanks once again for taking the time to review. > > > > Best regards, > > > > On Tue, Jan 29, 2019 at 3:42 PM Prashant Malani > > wrote: > > > >> Interesting. Thanks for pointing that out, Clemens. > >> > >> In any case, I've sent both versions (atoi v/s strtol), so whichever one > >> is preferred can be used (would be slightly inclined towards atoi, since > >> it's used elsewhere in the file, and because of Clemens' comment; > >> additionally, there is less code duplication with the atoi version). > >> > >> Best regards, > >> > >> On Tue, Jan 29, 2019 at 8:19 AM Clemens Ladisch > >> wrote: > >> > >>> Takashi Sakamoto wrote: > >>> > When parsing string with non-numeric characters, the behaviour of > >>> > atoi() is undefined still in C11. > >>> > >>> A completely non-numeric string is specified to return zero. > >>> > >>> The behaviour is undefined only if the value cannot be represented, i.e., > >>> if it overflows. > >>> > >>> > >>> Regards, > >>> Clemens > >>> > >> > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >