From: Takashi Iwai Subject: Re: [PATCH, alsa-lib] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() Date: Wed, 28 Feb 2018 16:29:30 +0100 Message-ID: References: <20180227203317.17274-2-k.marinushkin@gmail.com> <20180227203541.17343-1-k.marinushkin@gmail.com> <20180228152403.GB6722@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id DE0332671A8 for ; Wed, 28 Feb 2018 16:29:32 +0100 (CET) In-Reply-To: <20180228152403.GB6722@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Pan Xiuli , Pierre-Louis Bossart , Liam Girdwood , Kirill Marinushkin List-Id: alsa-devel@alsa-project.org On Wed, 28 Feb 2018 16:24:03 +0100, Mark Brown wrote: > > On Tue, Feb 27, 2018 at 09:35:41PM +0100, Kirill Marinushkin wrote: > > The values of bclk and fsync are inverted WRT the codec. But the existing > > solution already works for Broadwell, see the alsa-lib config: > > You should include Jaroslav and Takashi when sending alsa-lib patches. Yep, please at the next time. (And, don't stick with an old thread, but refresh a new thread.) > > > + /* For backwards capability, > > + * "master" == "codec is slave" > > + */ > > + if (!strcmp(val, "master") || > > + !strcmp(val, "codec_slave")) > > + hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CS; > > + else if (!strcmp(val, "codec_master")) > > + hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CM; > > Should we warn on use of "master" since it's being deprecated here (and > might be confusing for users)? Maybe. OTOH, it looks fully backward-compatible, so far, so it's not that confusing yet. thanks, Takashi