From: Takashi Iwai Subject: Re: [PATCH] topology: delete output file if parsing fails. Date: Sat, 10 Jun 2017 11:35:46 +0200 Message-ID: References: <1497022422-5974-1-git-send-email-liam.r.girdwood@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 616AD266819 for ; Sat, 10 Jun 2017 11:35:46 +0200 (CEST) In-Reply-To: <1497022422-5974-1-git-send-email-liam.r.girdwood@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Fri, 09 Jun 2017 17:33:42 +0200, Liam Girdwood wrote: > > Currently the binary output file is left when parsing fails. This confuses > GNU Make if the parsing fails and causes the compilation to partially > complete. > > Signed-off-by: Liam Girdwood Applied, thanks. But at the next time, please specify which repo to apply. It took some time until I figured out it's for alsa-utils. Takashi > --- > topology/topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/topology/topology.c b/topology/topology.c > index 6d876ee..097c255 100644 > --- a/topology/topology.c > +++ b/topology/topology.c > @@ -108,6 +108,7 @@ int main(int argc, char *argv[]) > if (err < 0) { > fprintf(stderr, _("failed to compile context %s\n"), source_file); > snd_tplg_free(snd_tplg); > + unlink(output_file); > return 1; > } > > -- > 2.11.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >