From: Takashi Iwai Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Date: Sun, 21 May 2017 09:09:21 +0200 Message-ID: References: <1495021136-6999-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BDFFA266D55 for ; Sun, 21 May 2017 09:09:22 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Bhumika Goyal Cc: Julia Lawall , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 17 May 2017 14:33:45 +0200, Bhumika Goyal wrote: > > On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 13:38:56 +0200, > > Bhumika Goyal wrote: > >> > >> Declare snd_kcontrol_new structures as const as they are only passed an > >> argument to the function snd_ctl_new1. This argument is of type const, > >> so snd_kcontrol_new structures having this property can be made const. > >> Done using Coccinelle: > >> > >> @r disable optional_qualifier@ > >> identifier x; > >> position p; > >> @@ > >> static struct snd_kcontrol_new x@p={...}; > >> > >> @ok@ > >> identifier r.x; > >> position p; > >> @@ > >> snd_ctl_new1(&x@p,...) > >> > >> @bad@ > >> position p != {r.p,ok.p}; > >> identifier r.x; > >> @@ > >> x@p > >> > >> @depends on !bad disable optional_qualifier@ > >> identifier r.x; > >> @@ > >> +const > >> struct snd_kcontrol_new x; > >> > >> Signed-off-by: Bhumika Goyal > > > > As I already asked, could you send as a patchset if you have multiple > > similar patches? > > > > Sure. Will combine the already sent ones and some new ones into a > patchset and send again. Well, since there haven't been new submissions and the patches are trivial, I applied the existing four patches. If you have newer ones, please submit as a patchset. thanks, Takashi