From: Takashi Iwai Subject: Re: [PATCH 00/25] line6usb cleanup Date: Mon, 12 Jan 2015 23:07:08 +0100 Message-ID: References: <1420868171-2031-1-git-send-email-chris@rorvick.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Chris Rorvick Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org, Peter P Waskiewicz Jr , Fabian Mewes , Gulsah Kose , Stefan Hajnoczi , Greg Kroah-Hartman , Mikhail Boiko , Monam Agarwal , linux-kernel@vger.kernel.org, Himangi Saraogi , Alexey Khoroshilov List-Id: alsa-devel@alsa-project.org At Mon, 12 Jan 2015 17:35:01 +0100, Takashi Iwai wrote: > > At Sun, 11 Jan 2015 15:04:55 -0600, > Chris Rorvick wrote: > > > > > At Fri, 9 Jan 2015 23:35:46 -0600, > > > Chris Rorvick wrote: > > >> > > >> I have a TonePort UX2 that I've used for testing, meaning that some of > > >> this is really only compile-tested. > > > > > > If anyone is responsible for testing with real hardware, I'll happily > > > review. > > > > To be clear, the TonePort UX2 is real hardware. But this driver > > basically supports four classes of Line 6 devices and I'm only covering > > one of them. > > > > So this series is a first step in trying to address this. Having this > > as a single driver probably made sense when it was a separate project, > > but now that it is in-tree it seems like the POD, PODHD, TonePort, and > > Variax pieces should each be separate drivers that each depend on a core > > Line 6 driver. I think the cleanup in this series will make that > > easier. None of this is my area of expertise, though, so advice and > > feedback is very welcome. > > > > > are there any active developers for this driver? > > > > I intended to do further work. I know there is quite a bit of mundane > > checkpatch cleanup that would need to get done before this could get > > promoted, and I believe I read that it's using sysfs for stuff that > > would normally be done via an ALSA interface, and the sysfs interface > > has not been documented nor has it been justified. All stuff I thought > > I might look into. > > > > But I'm just doing this for fun so I can't promise anything. :-) > > OK, so the situation looks fairly good, we have a few active > developers and/or testers. And the current code doesn't look so > terrible despite of it being in staging directory. That said, I think > we can promote this stuff into sound/usb/line6 directory, then apply > Chris' cleanup patches, and work on it further. > > Does it sound OK for you guys? Greg? > > Once when I get approval, I'll start a new clean branch on sound.git > tree so that you guys can work on it further for 3.20 kernel. JFYI, I merged all patches Greg forwarded to me into topic/line6 branch of sound git tree. It's included to linux-next, so you can work on linux-next or my branch as well. Now the code has been moved from driver/staging/line6 to sound/usb/line6. I'm going to apply some driver rename and cleanup patches to follow to other ALSA driver standards, and think of splitting to each driver with a core line6 helper module after that. Feel free to send the further development patches to me and/or alsa-devel ML like other sound drivers. thanks, Takashi