From: Takashi Iwai Subject: Re: hda_analyzer vs alc668 asus NJ750k Date: Wed, 30 Jul 2014 10:50:15 +0200 Message-ID: References: <59001.86.107.254.57.1406639342.squirrel@boosthardware.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6155526072A for ; Wed, 30 Jul 2014 10:50:16 +0200 (CEST) In-Reply-To: <59001.86.107.254.57.1406639342.squirrel@boosthardware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Patrick Shirkey Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 29 Jul 2014 23:09:02 +1000 (EST), Patrick Shirkey wrote: > > Hi, > > I get some errors running hda_analyzer with this alc668 chipset. > > Traceback (most recent call last): > File "/dev/shm/hda-analyzer/hda_analyzer.py", line 546, in > sys.exit(main(sys.argv)) > File "/dev/shm/hda-analyzer/hda_analyzer.py", line 523, in main > if read_nodes(sys.argv[1:]) == 0: > File "/dev/shm/hda-analyzer/hda_analyzer.py", line 89, in read_nodes > read_nodes2(c.card, i) > File "/dev/shm/hda-analyzer/hda_analyzer.py", line 60, in read_nodes2 > c = HDACodec(card, codec) > File "/dev/shm/hda-analyzer/hda_codec.py", line 1041, in __init__ > self.parse_proc() > File "/dev/shm/hda-analyzer/hda_codec.py", line 1140, in parse_proc > self.proc_codec = HDACodecProc(self.card, self.device, file) > File "/dev/shm/hda-analyzer/hda_proc.py", line 479, in __init__ > self.parse(proc_file) > File "/dev/shm/hda-analyzer/hda_proc.py", line 677, in parse > node.add_digital(line[11:]) > File "/dev/shm/hda-analyzer/hda_proc.py", line 296, in add_digital > self.wrongfile('unknown dig1 bit %s' % repr(b)) > File "/dev/shm/hda-analyzer/hda_proc.py", line 143, in wrongfile > raise ValueError, "wrong proc file format (%s)" % msg > ValueError: wrong proc file format (unknown dig1 bit 'KAE') > > > If I disable the check for add_digital I get this error: > > ValueError: wrong proc file format ( Digital: Enabled KAE) > > - Is it a problem to add a new DIG1_BIT to hda_proc.py:277 > > def add_digital(self, line): > bits = { > 'Enabled': DIG1_BITS['ENABLE'], > 'Validity': DIG1_BITS['VALIDITY'], > 'ValidityCfg': DIG1_BITS['VALIDITYCFG'], > 'Preemphasis': DIG1_BITS['EMPHASIS'], > 'Copyright': DIG1_BITS['COPYRIGHT'], # old buggy format > 'Non-Copyright': DIG1_BITS['COPYRIGHT'], > 'Non-Audio': DIG1_BITS['NONAUDIO'], > 'Pro': DIG1_BITS['PROFESSIONAL'], > 'GenLevel': DIG1_BITS['LEVEL'], > 'KAE': DIG1_BITS['KAE'], > } > > hda_codec.py:224 > > DIG1_BITS = { > 'ENABLE': 0, > 'VALIDITY': 1, > 'VALIDITYCFG': 2, > 'EMPHASIS': 3, > 'COPYRIGHT': 4, > 'NONAUDIO': 5, > 'PROFESSIONAL': 6, > 'LEVEL': 7, > 'KAE': 8 > } KAE belongs to DIG3, so shouldn't be there. I updated the git repo now. While we are at it: it would make sense to move this from alsa to alsa-tools repo, IMO. Jaroslav, any objection? The only question is the installation to the system, though. Takashi