From: Takashi Iwai Subject: Re: Possible problem with cmipci driver Date: Sun, 11 Nov 2012 10:16:32 +0100 Message-ID: References: <20121110112006.7c5c505c@chukar.edge2.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 66E2D2616D2 for ; Sun, 11 Nov 2012 10:16:33 +0100 (CET) In-Reply-To: <20121110112006.7c5c505c@chukar.edge2.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jake Edge Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 10 Nov 2012 11:20:06 -0700, Jake Edge wrote: > > > Hi Takashi, Jaroslav, and other sound developers, > > Maybe I am way off base, but I think there may be a bug relatively > recently introduced into the cmipci driver. I note that Takashi has > made some changes in July (commit: > 68cb2b559278858ef9f3a7722f95df88797c7840 ) that might (?) be relevant. If the above commit is the culprit, does the patch below help? Takashi --- diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c index 22122ff..ae41982 100644 --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -3368,7 +3368,7 @@ static int snd_cmipci_suspend(struct device *dev) pci_disable_device(pci); pci_save_state(pci); - pci_set_power_state(pci, PCI_D3hot); + pci_set_power_state(pci, pci_choose_state(pci, PMSG_SUSPEND)); return 0; }