From: Takashi Iwai Subject: Re: [PATCH] Fix "alc262_sony_unsol[]" hda_verb array Date: Mon, 09 Jun 2008 18:31:55 +0200 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id D411F10383E for ; Mon, 9 Jun 2008 18:31:56 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: idak Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 9 Jun 2008 22:46:07 +0900, idak wrote: > > I think that hda_verb array must have "terminator (empty array)". > But alc262_sony_unsol[] does not have it. > And it causes gcc-4.3's buggy behavior > with snd_hda_sequence_write(). > > Signed-off-by: Akio Idehara Ouch, it was obviously overlooked... I took both patches, and try to push this one to the upstream. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > --- a/sound/pci/hda/patch_realtek.c 2008-06-08 19:23:57.000000000 +0900 > +++ b/sound/pci/hda/patch_realtek.c 2008-06-08 19:42:19.000000000 +0900 > @@ -8839,6 +8839,7 @@ static struct hda_verb alc262_sony_unsol > > {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN | ALC880_HP_EVENT}, > {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, > + {} > }; > > /* mute/unmute internal speaker according to the hp jack and mute state */ > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >