Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FA5C4338F for ; Tue, 17 Aug 2021 10:15:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BDF660F58 for ; Tue, 17 Aug 2021 10:15:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4BDF660F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4AAEF822; Tue, 17 Aug 2021 12:14:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4AAEF822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629195334; bh=luVFRKpleAqjKrTUOHpzPLmHmlsM8HhqvXOeftXX4d8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WfyibK+DGhSIgNnp/q/Tfzixw5R0Ed0nrX0btJgFHFqt4Ajdhn2W9Dr/oLSj27mp3 igjBrQpgES7RpS6MXf7SiRA09qOYsd25jhc1hpitr9+tfqRL6RAMgiUDLcgMkmzyN6 Utk+OFkJkAq3DXudq+wq9N3VlevSS7D6fYooh/28= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D5311F80111; Tue, 17 Aug 2021 12:14:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D216DF80272; Tue, 17 Aug 2021 12:14:33 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62CA1F80111 for ; Tue, 17 Aug 2021 12:14:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62CA1F80111 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mSzrE77B"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0uYo6v2y" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3E12821D61; Tue, 17 Aug 2021 10:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629195267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=la3XYyb0MzVv8C/omOJxVo3ZkJFqr7Dh8EpDVAGhlbc=; b=mSzrE77Bawo0XDpvuG1MkwJEWzuhaJ5IKh1cuE0aGFN9odwiOGa3SGNU5xNk6o+QtjaF0S XOW5G+/cJuJ0NDZoPrWkkjfECBZ7sePF0SyCBme3Fw2wtZ8CBNVo73KzMaGnFerqdSr5JA wyzb67JUHbEefFgLfPZBRCb+UIpyFkM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629195267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=la3XYyb0MzVv8C/omOJxVo3ZkJFqr7Dh8EpDVAGhlbc=; b=0uYo6v2y5U6iYAYm0Vz8hucuZWvM2wCnsBuCf25mgctTDskgwsR0cuubMKFL9e/E9OCCWP tZezdbJw+QPal+Aw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 33660A3B99; Tue, 17 Aug 2021 10:14:27 +0000 (UTC) Date: Tue, 17 Aug 2021 12:14:27 +0200 Message-ID: From: Takashi Iwai To: David Henningsson Subject: Re: [PATCH 0/2] alsa-lib patches for rawmidi tstamp framing In-Reply-To: <458d04a3-5e99-d96f-b930-1b09044656d1@diwic.se> References: <20210816160625.17796-1-coding@diwic.se> <458d04a3-5e99-d96f-b930-1b09044656d1@diwic.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 17 Aug 2021 12:07:39 +0200, David Henningsson wrote: > > > On 2021-08-17 07:35, Takashi Iwai wrote: > > On Mon, 16 Aug 2021 18:06:23 +0200, > > David Henningsson wrote: > >> Well, now that we're about to release a kernel with support for rawmidi tstamp framing, > >> how about some alsa-lib support for it as well? > > Sure, that's the missing piece. > > But, could you give a bit more description to each patch? > Do you mean commit message? Yes. > I could just write this for patch 1/2 (i e, copy the doc section added > in the patch): > > Optionally, incoming rawmidi bytes can be put inside a frame of type snd_rawmidi_framing_tstamp_t. > The main current benefit is that can enable in-kernel timestamping of incoming bytes, and that > timestamp is likely to be more precise than what userspace can offer. > > Tstamp type framing requires a kernel >= 5.14 and a buffer size that is a multiple of > sizeof(snd_rawmidi_framing_tstamp_t). It is only available on input streams. > > And this for patch 2/2: > > Adds a "clock type" parameter to the "rawmidi" test program, that when > used and combined with -i (and -v to be useful), activates tstamp type > framing with the specified clock type. > > I hope this description makes it possible for you to review the patch > content as well. The texts look OK, please resubmit. thanks, Takashi