Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E2FC4338F for ; Sun, 1 Aug 2021 07:40:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4751D61042 for ; Sun, 1 Aug 2021 07:40:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4751D61042 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4374918AE; Sun, 1 Aug 2021 09:39:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4374918AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627803610; bh=9F1VqoWBXSpS7L6hJtxY95BA2dga/0P1ExWGkbpKngY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O3OfrSHhEFQoS/0MhNQbTzTpRRF1Z7UXf6Lsv5bZLtUsJdoYzx0JDF/dqV2w+Hf6k dpJ5Dzs2fwpmJjM5PLb1MT+7RXG304lU4CJiH2wpeNa+HfekurSqOo/RqgGKTreY3d EkSy0bVagxwLz8UlXH24uF9+fEhws7aAExmxNcq4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C95F8F8012E; Sun, 1 Aug 2021 09:39:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58BA7F802E8; Sun, 1 Aug 2021 09:39:18 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D93AAF8012E for ; Sun, 1 Aug 2021 09:39:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D93AAF8012E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EKBJ4V05"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VEuEXi9D" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8BE841FEB5; Sun, 1 Aug 2021 07:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627803553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GS1k/+KLd6UXkQMtahglCC90D31kziwwPHjdLxyERE0=; b=EKBJ4V05t9EXzcKu6MwuRvq50O72KO8/JhHIl38CwQBs0iB5SQQwuNTPymO4xp3yWPiJn6 hl9GuyBWdhTh1kvwi4PisNWgWRWRaWHsxBvE2S4m7/yzpovGLhx/bLNYLWJvyoWQuApAIC 2lYix+K2a4T8/s2LN2NelxGrsCM3QZQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627803553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GS1k/+KLd6UXkQMtahglCC90D31kziwwPHjdLxyERE0=; b=VEuEXi9D44igkFVVG2cLdrYSPqmzITUYhIQc1gO4FWQG6kNk8bFdXou6z8SfC7b02qStb7 5zgWPSX3449lbDCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 80B1DA3BAC; Sun, 1 Aug 2021 07:39:13 +0000 (UTC) Date: Sun, 01 Aug 2021 09:39:13 +0200 Message-ID: From: Takashi Iwai To: Alexander Monakov Subject: Re: [PATCH] ALSA: hda/realtek: add mic quirk for Acer SF314-42 In-Reply-To: References: <20210721170141.24807-1-amonakov@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Nikos Liolios , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 01 Aug 2021 09:00:48 +0200, Alexander Monakov wrote: > > On Sun, 1 Aug 2021, Nikos Liolios wrote: > > > Other quirks for Acer Swift (for Acer SWIFT SF314-54/55/56) they describe the > > model using capital letters ("SWIFT" instead of "Swift"). I do think that > > "Swift" is better than (caps locked) "SWIFT". Thinking to create a patch for > > it since I helped to create this mess. From my understanding it only affects > > the dmesg of which quirk was used, nothing important, but lets keep code > > clean. > > > > What do you think? Rename "SWIFT"s to "Swift"s? > > If no disagreement or no reply I am doing it like tomorrow. > > I agree "Swift" would be better: as far as I can tell, Acer mostly uses "Swift" > (both in marketing materials and DMI information). I would support the rename. That's a really bikeshed topic, and I don't think we need an extra patch to correct it. The message is only for debug prints, usually you don't see it. thanks, Takashi