Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3CDC4727F for ; Wed, 30 Sep 2020 09:22:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E912076B for ; Wed, 30 Sep 2020 09:22:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="VEEO138a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E912076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AD69B17F1; Wed, 30 Sep 2020 11:21:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AD69B17F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601457746; bh=v973pmYbEw7t/FDVYNlvn7DbcdhU4qRJjtOMa6Ip+MI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VEEO138axamBGadiziG21ne7PF5BMJTWPGXRAiqNu+fpfEVo9fyhbVYvlPTFmL8/T e75NSUP/7yrYIiH7Pdg5A+LcldKaylJCcOMVEbtvAARpOZxqlznyfAdCLm6Z6I/bpk lilj/61vXNFwNl1j8g47hz34uiJhcnvz2TdKD8OE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 43096F801D8; Wed, 30 Sep 2020 11:21:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A4CDF801ED; Wed, 30 Sep 2020 11:21:34 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19459F800AB for ; Wed, 30 Sep 2020 11:21:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19459F800AB X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1CBF8B018; Wed, 30 Sep 2020 09:21:25 +0000 (UTC) Date: Wed, 30 Sep 2020 11:21:24 +0200 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: hda - Don't register a cb func if it is registered already In-Reply-To: References: <20200930055146.5665-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Hui Wang , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 30 Sep 2020 09:19:50 +0200, Jaroslav Kysela wrote: > > Dne 30. 09. 20 v 7:51 Hui Wang napsal(a): > > If the caller of enable_callback_mst() passes a cb func, the callee > > function will malloc memory and link this cb func to the list > > unconditionally. This will introduce problem if caller is in the > > hda_codec_ops.init() since the init() will be repeatedly called in the > > codec rt_resume(). > > > > So far, the patch_hdmi.c and patch_ca0132.c call enable_callback_mst() > > in the hda_codec_ops.init(). > > Won't be better to handle this double invocation at the callback call time? I > believe that some refcounting and pointing to one allocated callback structure > for all instances is better. IMO, Hui's fix is correct in this case; otherwise it'll result in endless number of allocations at each time the runtime resume is performed. So I'm going to take it as is. For ca0132, though, the simplest fix would be to just move ca0132_init_unsol() call into patch_ca0132(). But the additional fix in hda_jack side would be good in anyway. thanks, Takashi