Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BD4C3A5A5 for ; Thu, 5 Sep 2019 13:17:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38BE8206BB for ; Thu, 5 Sep 2019 13:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="VUEBVfYK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38BE8206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D757A168E; Thu, 5 Sep 2019 15:16:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D757A168E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567689446; bh=hFbF8b3CXwaVSm702Ewr07si62Nm8OKkXHbUThW/c1w=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VUEBVfYKszg04/aXepTYowGUxSFgkaIzXx0gEDtDx5VNyEQEu7mlLQ5N4Rdz2WZGa WtwgPAM1X3PXjOBjyDMavm1ttB5cmus0/tRXTcLNbydI9kt3L5R3+dup6IvOR3mHHb U3SULSFUt7f9CP9iTujzl4fwoD2wfbInMDh9/9hY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3B58AF80448; Thu, 5 Sep 2019 15:16:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EB4AFF804A9; Thu, 5 Sep 2019 15:16:33 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 31302F803D1; Thu, 5 Sep 2019 15:16:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 31302F803D1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4911EAF32; Thu, 5 Sep 2019 13:16:28 +0000 (UTC) Date: Thu, 05 Sep 2019 15:16:28 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart In-Reply-To: <9b997691-a609-e7b5-94a6-d42e26dfa080@linux.intel.com> References: <20190905053302.9262-1-pawel.harlozinski@linux.intel.com> <20190905053302.9262-2-pawel.harlozinski@linux.intel.com> <9b997691-a609-e7b5-94a6-d42e26dfa080@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: cezary.rojewski@intel.com, patch@alsa-project.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, broonie@kernel.org, Pawel Harlozinski Subject: Re: [alsa-devel] [RFC PATCH 2/3] ALSA:core: Add rate 24kHz X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 05 Sep 2019 15:11:43 +0200, Pierre-Louis Bossart wrote: > > On 9/5/19 12:48 AM, Takashi Iwai wrote: > > On Thu, 05 Sep 2019 07:33:00 +0200, > > Pawel Harlozinski wrote: > >> > >> Adds SNDRV_PCM_RATE_24000 at the bottom to keep backward compability > >> with alsa library. > >> > >> Signed-off-by: Pawel Harlozinski > > > > No. Such a fancy rate has to be handled inside the driver locally > > instead of adding to the common rate. > > It's not that crazy, this is supported in the HDaudio spec: > > Sample Base Rate Divisor (DIV): > 000 = Divide by 1 (48 kHz, 44.1 kHz) > 001 = Divide by 2 (24 kHz, 22.05 kHz) > > I am not sure why 22.05 made the cut and not 24 kHz, they are both > derived from common clocks with the same divider... Same for 11.025 > and 12... I'm not against supporting it. It'd be fine if it were the changes that are applied only to HD-audio driver side. What I'm against is to change the ALSA PCM core. It's not necessarily done there at all. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel