From: Takashi Iwai Subject: Re: [PATCH v2] aplay: Fix error message when writing captured data Date: Fri, 07 Apr 2017 15:27:51 +0200 Message-ID: References: <1491571236-23476-1-git-send-email-daniel.baluta@nxp.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B7F3F2664EB for ; Fri, 7 Apr 2017 15:27:52 +0200 (CEST) In-Reply-To: <1491571236-23476-1-git-send-email-daniel.baluta@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Baluta Cc: alsa-devel@alsa-project.org, shengjiu.wang@nxp.com, o-takashi@sakamocchi.jp, broonie@kernel.org, viorel.suman@nxp.com, mihai.serban@nxp.com List-Id: alsa-devel@alsa-project.org On Fri, 07 Apr 2017 15:20:36 +0200, Daniel Baluta wrote: > > Read can return less then requested bytes, but we treat > this as an error. Actually that's the bug -- we should loop the write until it reaches to the real error. Once when we get the proper errno, the error message via perror() itself will be enough. thanks, Takashi > Anyhow, errno is not updated in this case and we can end > up with a confusing error message. > > For example, when there is no room to write data into the > output file we receive: > > $ arecord -d 2000 -c 2 -r 192000 -f S16_LE -Dplughw:0,0 audio.wav > Recording WAVE '/mnt/msc/audio.wav' : Signed 16 bit Little Endian, Rate > 192000 Hz, Stereo > audio.wav: No such file or directory > > Signed-off-by: Daniel Baluta > --- > aplay/aplay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/aplay/aplay.c b/aplay/aplay.c > index ee480f2..96f5e1b 100644 > --- a/aplay/aplay.c > +++ b/aplay/aplay.c > @@ -3079,7 +3079,7 @@ static void capture(char *orig_name) > break; > } > if (write(fd, audiobuf, c) != c) { > - perror(name); > + fprintf(stderr, _("Couldn't write all data to %s\n"), name); > in_aborting = 1; > break; > } > -- > 2.7.4 >