From: Takashi Iwai Subject: Re: [PATCH] ALSA: compress: add num_sample_rates in snd_codec_desc Date: Tue, 07 Jan 2014 18:41:35 +0100 Message-ID: References: <1389111942-20810-1-git-send-email-vinod.koul@intel.com> <20140107173510.GD31886@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 98F36264EF3 for ; Tue, 7 Jan 2014 18:41:35 +0100 (CET) In-Reply-To: <20140107173510.GD31886@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Vinod Koul , alsa-devel@alsa-project.org, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org At Tue, 7 Jan 2014 17:35:10 +0000, Mark Brown wrote: > > On Tue, Jan 07, 2014 at 09:55:42PM +0530, Vinod Koul wrote: > > > struct snd_codec_desc { > > __u32 max_ch; > > __u32 sample_rates[MAX_NUM_SAMPLE_RATES]; > > + __u32 num_sample_rates; > > __u32 bit_rate[MAX_NUM_BITRATES]; > > __u32 num_bitrates; > > __u32 rate_control; > > This is adding a field to the userspace ABI which will break it... not > sure if we care or not but it probably ought to be noted in the commit > log at the very least; people do build things like distros with headers > from older kernels than the ones they run. The previous commit for sample_rates[] already broke it, so it doesn't matter for this commit :) I applied the update patches since snd_codec_desc isn't used anywhere in the upstream code, and this is the request from Vinod, so he must know well the ABI regression if it really matters. Takashi