From: Takashi Iwai Subject: Re: [PATCHv2] ALSA: usb-audio: hiface: return correct XRUN indication Date: Wed, 24 Jul 2013 12:06:11 +0200 Message-ID: References: <1374570906-1075-1-git-send-email-eldad@fogrefinery.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 65865265251 for ; Wed, 24 Jul 2013 12:05:04 +0200 (CEST) In-Reply-To: <1374570906-1075-1-git-send-email-eldad@fogrefinery.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Eldad Zack Cc: Antonio Ospite , alsa-devel@alsa-project.org, Clemens Ladisch List-Id: alsa-devel@alsa-project.org At Tue, 23 Jul 2013 11:15:06 +0200, Eldad Zack wrote: > > Return SNDRV_PCM_POS_XRUN (snd_pcm_uframes_t) instead of > SNDRV_PCM_STATE_XRUN (snd_pcm_state_t) from the pointer > function of hiface, as expected by snd_pcm_update_hw_ptr0(). > > Caught by sparse. > > Cc: Antonio Ospite > Signed-off-by: Eldad Zack Thanks, applied. Takashi > --- > * Corrected commit message > > sound/usb/hiface/pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/hiface/pcm.c b/sound/usb/hiface/pcm.c > index 6430ed2..c21a3df 100644 > --- a/sound/usb/hiface/pcm.c > +++ b/sound/usb/hiface/pcm.c > @@ -503,7 +503,7 @@ static snd_pcm_uframes_t hiface_pcm_pointer(struct snd_pcm_substream *alsa_sub) > snd_pcm_uframes_t dma_offset; > > if (rt->panic || !sub) > - return SNDRV_PCM_STATE_XRUN; > + return SNDRV_PCM_POS_XRUN; > > spin_lock_irqsave(&sub->lock, flags); > dma_offset = sub->dma_off; > -- > 1.8.1.5 >