From: Takashi Iwai Subject: Re: [PATCH] ALSA: pcm: Mostly constify constraints Date: Thu, 05 Jul 2012 12:41:05 +0200 Message-ID: References: <1341423313-9561-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20120705092841.GI4111@opensource.wolfsonmicro.com> <20120705103527.GM4111@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 5E1E8103EFB for ; Thu, 5 Jul 2012 12:41:07 +0200 (CEST) In-Reply-To: <20120705103527.GM4111@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 5 Jul 2012 11:35:28 +0100, Mark Brown wrote: > > On Thu, Jul 05, 2012 at 11:55:36AM +0200, Takashi Iwai wrote: > > > The rule->private pointer isn't designed to be always const. The data > > purely depends on each rule function, thus whether it can be const or > > not also depends on the rule, too. For simple rules like list take > > indeed the constant list. But more complex rules may take a struct > > containing variables changed on the fly (e.g. the max rate set by > > user via control API). > > Well, it's mostly const - it's const unless the rule itself starts > fiddling with stuff which I'd have expected to be the exception rather > than the rule. Well, the only rule is that rule (function) rules the meaning of the private pointer :) Takashi