From: Takashi Iwai Subject: Re: [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy Date: Mon, 01 Jun 2009 18:55:23 +0200 Message-ID: References: <1243719865-26760-1-git-send-email-daniel@caiaq.de> <1243719865-26760-2-git-send-email-daniel@caiaq.de> <1243719865-26760-3-git-send-email-daniel@caiaq.de> <20090601092354.GN26148@buzzloop.caiaq.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id EE48E1037FE for ; Mon, 1 Jun 2009 18:55:23 +0200 (CEST) In-Reply-To: <20090601092354.GN26148@buzzloop.caiaq.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 1 Jun 2009 11:23:54 +0200, Daniel Mack wrote: > > On Mon, Jun 01, 2009 at 10:32:21AM +0200, Takashi Iwai wrote: > > > Signed-off-by: Daniel Mack > > > > You should use strlcpy() instead of strncpy(). The latter doesn't > > terminate the oversized string. > > Right. Want me to resend or could you do that on the fly while > commiting? Well, I'm going to review the whole patches again tomorrow. Would be nice if you resend the latest fixed ones. thanks, Takashi