From: Takashi Iwai Subject: Re: [PATCH 1/1] ALSA: Fix limit of 8 PCM devices in SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE Date: Wed, 30 Jul 2008 18:37:55 +0200 Message-ID: References: <1217349266.29863.40.camel@bri1004.bri.st.com> <1217414748.29863.60.camel@bri1004.bri.st.com> <1217418400.29863.64.camel@bri1004.bri.st.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1217418400.29863.64.camel@bri1004.bri.st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Pawel MOLL Cc: alsa-devel@alsa-project.org, patch@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 30 Jul 2008 12:46:40 +0100, Pawel MOLL wrote: > > ALSA: Fix limit of 8 PCM devices in SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE > > When compiled with CONFIG_SND_DYNAMIC_MINORS the ALSA core is fine > to have more than 8 PCM devices per card, except one place - the > SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE ioctl, which will not enumerate > devices > 7. This patch fixes the issue, changing the devices list > organisation. > > Instead of adding new device to the tail, the list is now kept always > ordered (by card number, then device number). Thus, during enumeration, > it is easy to discover the fact that there is no more given card's > devices. > > Additionally the device field of struct snd_pcm had to be changed to int, > as its "unsignednity" caused a lot of problems when comparing it to > potentially negative signed values. (-1 is 0xffffffff or even more then ;-) > > Signed-off-by: Pawel Moll Thanks. Applied this one. Takashi