From: Takashi Iwai Subject: Re: 2.6.17-rc4-mm3-lockdep BUG: possible deadlock detected! Date: Tue, 30 May 2006 12:34:12 +0200 Message-ID: References: <6bffcb0e0605291132u701cd69tb855cf60fa317994@mail.gmail.com> <20060529114749.ba020660.akpm@osdl.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (ns2.suse.de [195.135.220.15]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 3EE29142 for ; Tue, 30 May 2006 12:34:13 +0200 (MEST) In-Reply-To: <20060529114749.ba020660.akpm@osdl.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Andrew Morton Cc: mingo@elte.hu, alsa-devel@alsa-project.org, Michal Piotrowski , perex@suse.cz, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Mon, 29 May 2006 11:47:49 -0700, Andrew Morton wrote: > > On Mon, 29 May 2006 20:32:47 +0200 > "Michal Piotrowski" wrote: > > > I get this with Ingo's lockdep patch from > > http://people.redhat.com/mingo/generic-irq-subsystem/ > > > > ==================================== > > [ BUG: possible deadlock detected! ] > > ------------------------------------ > > modprobe/592 is trying to acquire lock: > > (&grp->list_mutex){----}, at: [] > > snd_seq_port_connect+0xc0/0x337 [snd_seq] > > > > but task is already holding lock: > > (&grp->list_mutex){----}, at: [] > > snd_seq_port_connect+0x66/0x337 [snd_seq] > > > > which could potentially lead to deadlocks! > > > > other info that might help us debug this: > > 1 locks held by modprobe/592: > > #0: (&grp->list_mutex){----}, at: [] > > snd_seq_port_connect+0x66/0x337 [snd_seq] > > yes, > > down_write(&src->list_mutex); > down_write(&dest->list_mutex); > > I wonder if there's anything which prevents another task from concurrently > coming in and trying to perform the opposite connection and causing a > deadlock. I'm not 100% sure but I don't think the deadlock occurs because the object has actually two locks, namely, port.c_src.list_mutex port.c_dst.list_mutex so the above is equivalent with down(port_A.c_src.list_mutex); down(port_B.c_dst.list_mutex); When the opposite connection is performed concurrently, different locks are taken: down(port_B.c_src.list_mutex); down(port_A.c_dst.list_mutex); In the code, there is another place that using down_write() (in clear_subscriber_list()), but it's already after closing accesses to that port, hence there can be no race there. Takashi