From: Takashi Iwai Subject: Re: [PATCH 3/3] sound: don't call skl_init_chip() to reset intel skl soc Date: Tue, 11 Sep 2018 08:17:05 +0200 Message-ID: References: <20180910212150.202655-1-yuzhao@google.com> <20180910212358.203050-1-yuzhao@google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180910212358.203050-1-yuzhao@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Zhao Cc: Mark Brown , alsa-devel@alsa-project.org, Guneshwor Singh , Naveen Manohar , Pankaj Bharadiya , Rakesh Ughreja , Sanyog Kale , Sriram Periyasamy , Vinod Koul , Liam Girdwood , Pierre-Louis Bossart , Jie Yang , Jaroslav Kysela , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Mon, 10 Sep 2018 23:23:58 +0200, Yu Zhao wrote: > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > 1) sets bus->chip_init to prevent multiple entrances before device > is stopped; 2) enables interrupt. > > We shouldn't use it for the purpose of resetting device only because > 1) when we really want to initialize device, we won't be able to do > so; 2) we are ready to handle interrupt yet, and kernel crashes when > interrupt comes in. > > Rename azx_reset() to snd_hdac_bus_reset_link(), and use it to reset > device properly. > > Fixes: 60767abcea3d ("ASoC: Intel: Skylake: Reset the controller in probe") > Signed-off-by: Yu Zhao That makes sense. And I noticed that the legacy HD-audio driver potentially needs the same reset (although we haven't heard of any problem for years). So now I wonder whether this requirement of reset is really mandatory for the real hardware, or just theoretical... In anyway, Reviewed-by: Takashi Iwai thanks, Takashi