From: Takashi Iwai Subject: Re: [PATCH 00/11] Add Recon3D support + Driver cleanup Date: Wed, 08 Aug 2018 20:43:22 +0200 Message-ID: References: <1533749663-8200-1-git-send-email-conmanx360@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1533749663-8200-1-git-send-email-conmanx360@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Connor McAdams Cc: alsa-devel@alsa-project.org, Alastair Bridgewater , Jaroslav Kysela , Takashi Sakamoto , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 08 Aug 2018 19:34:11 +0200, Connor McAdams wrote: > > This patch series adds support for the Recon3D PCI-E card. I have > personally tested it on a Recon3D that was sent to me, and included > that PCI ID in the quirk table. > > Much of this patch series renames Recon3Di functions to just r3d > because both cards behave similarly. All patches look well cooked. I applied all 11 patches now. > Aside from that, I do have a question- If the PCI ID's are included in > the Window's driver .inf file, would I be good to add them in as > quirks? Or should I wait for someone with the card to test it, and > then add it once I know it works on that specific card? Such a decision depends on the situation, and in the case of CA0132, we can take them, I suppose. The boards don't work properly without the explicit fixes, so it can't be worse, after all :) Thanks! Takashi